Add new ne30 grids with active MALI #3069

jhkennedy · 2019-07-13T21:10:45Z

Adds two new ne30 grids with an active (but not dynamic) MALI component, with a new combined Antarctic and Greenland ice sheet model. Importantly, without an active MALI component, ELM cannot compute the required variables needed analyze the (snow) surface mass balance. This will allow SMB analysis for the low res watercycle and cryosphere campaigns, which is critically important for:

new snow model physics being developed
updating the ELM-->MALI downscaling
prepping/validation for v3 runs with dynamic ice sheet model runs.

The grids are: ne30_oECv3_aisgis and ne30_oECv3wLI_aisgis

[BFB]

Now, the mapping files, land surface data, land topography, and glacier mask files are all compatible. I was able to sucessfully run 10 years w/ MALI

components/clm/bld/namelist_files/namelist_defaults_clm4_5.xml

matthewhoffman

@jhkennedy , thanks for getting this PR in - this will be a big step forward in the SMB work to have the dual ice sheet grids available out of the box.

My review by inspection includes some questions about the mapping file definitions. Otherwise everything looks as I would expect. @jonbob might notice details I have not.

cime/config/e3sm/config_grids.xml

jonbob · 2019-07-25T14:49:58Z

@jhkennedy - does this PR need the newer version of MALI (in PR 3032) before it can be merged?

stephenprice · 2019-07-25T15:07:18Z

@jonbob -- I'm 99% sure these are entirely separate. That is, the features in this PR can operate independent of the changes being merged in as part of 3032.

jhkennedy · 2019-07-25T15:20:57Z

@jonbob yep, @stephenprice got it -- they are (or at least should be) independent.

jonbob · 2019-07-25T15:25:31Z

@jhkennedy - do you know if LND <=> GLC mapping requires the "mono" and "intbilin" methods? I have to admit I'm not clear on this, and @matthewhoffman is out of town

matthewhoffman · 2019-07-25T15:29:11Z

I don't know the answer without looking into the code. :-(

…

On Thu, Jul 25, 2019, 11:25 AM Jon Wolfe ***@***.***> wrote: @jhkennedy <https://github.com/jhkennedy> - do you know if LND <=> GLC mapping requires the "mono" and "intbilin" methods? I have to admit I'm not clear on this, and @matthewhoffman <https://github.com/matthewhoffman> is out of town — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3069?email_source=notifications&email_token=AA75AER7IE2DLCNL5XNXHYTQBHAW3A5CNFSM4IDCLILKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Z2L4Y#issuecomment-515089907>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA75AEV3NCKODHEY5SRAJBTQBHAW3ANCNFSM4IDCLILA> .

mt5555 · 2019-07-25T15:42:28Z

FYI: both maps are monotone. intbilin is more accurate but not conservative. mono is less accurate but conservative.

jonbob · 2019-07-25T17:05:19Z

Thanks @mt5555 - I think it makes sense for the mappings to be consistent, so we'll discuss and fix this PR. But we may ask your advice on which maps to use.

jonbob · 2019-07-30T19:16:33Z

@bishtgautam - can you please look at this comment above? I think the landice people are using an older file because it contains glc elevation class information that the newer one does not? If so, is there anyway to update the newer file to make it usable for their purposes? Thanks for your help!

bishtgautam · 2019-07-30T22:11:53Z

I will regenerate the land surface for ne30np4 for 2000 to include glacier elevation class and get back to you.

bishtgautam · 2019-07-30T22:58:28Z

@jhkennedy, The new land surface dataset that is available on blues/anvil at the following path:
/home/ccsm-data/inputdata/lnd/clm2/surfdata_map/surfdata_ne30np4_simyr2000_c190730.nc
Could you test it out? Thanks.

jhkennedy · 2019-07-31T11:49:38Z

Great, thanks @bishtgautam! I'll kick off a couple of runs today.

jonbob · 2019-07-31T14:47:58Z

Thanks @bishtgautam!

matthewhoffman · 2019-07-31T16:22:02Z

@jhkennedy , check out the comment I added at the bottom of this thread: https://acme-climate.atlassian.net/wiki/spaces/PROBSLR/pages/1003323510/Figures+for+SciDAC+PI+meeting+July+16--18+2019?focusedCommentId=1004503418#comment-1004503418
I think it might explain the grid imprinting issue you were seeing. It would be great if we are able to resolve that in this PR. I think it might just require a change in the LND2GLC State mapping method.

jhkennedy · 2019-07-31T16:29:29Z

@matthewhoffman I'll try it with the other mappings as well. For sure, I'd like to get that sorted here as well.

jhkennedy · 2019-08-07T15:00:52Z

@matthewhoffman I think we've sorted the grid imprinting issues, see my reply here.

I think everything here is ready to go at this point

matthewhoffman · 2019-08-07T15:04:37Z

@jhkennedy , that looks great! I'll coordinate with @jonbob to do a final review and testing to get this merged.

cime/config/e3sm/config_grids.xml

Add new ne30 grids with active MALI This PR adds two new grids, ne30_oECv3_aisgis and ne30_oECv3wLI_aisgis, for configurations with an active (but not dynamic) MALI component using a combined Antarctic and Greenland ice sheet model. Without the active MALI component, ELM cannot compute the required variables needed analyze the (snow) surface mass balance. This will allow SMB analysis for the low-res watercycle and cryosphere campaigns, which is critically important for: * new snow model physics being developed * updating the ELM-->MALI downscaling * prepping/validation for v3 runs with dynamic ice sheet model runs. [BFB]

jonbob · 2019-08-07T19:26:19Z

merged to next

Add new ne30 grids with active MALI This PR adds two new grids, ne30_oECv3_aisgis and ne30_oECv3wLI_aisgis, for configurations with an active (but not dynamic) MALI component using a combined Antarctic and Greenland ice sheet model. Without the active MALI component, ELM cannot compute the required variables needed analyze the (snow) surface mass balance. This will allow SMB analysis for the low-res watercycle and cryosphere campaigns, which is critically important for: * new snow model physics being developed * updating the ELM-->MALI downscaling * prepping/validation for v3 runs with dynamic ice sheet model runs. [BFB]

jonbob · 2019-08-08T16:39:55Z

merged to master and NML DIFF blessed

Add new ne30 grids with active MALI This PR adds two new grids, ne30_oECv3_aisgis and ne30_oECv3wLI_aisgis, for configurations with an active (but not dynamic) MALI component using a combined Antarctic and Greenland ice sheet model. Without the active MALI component, ELM cannot compute the required variables needed analyze the (snow) surface mass balance. This will allow SMB analysis for the low-res watercycle and cryosphere campaigns, which is critically important for: * new snow model physics being developed * updating the ELM-->MALI downscaling * prepping/validation for v3 runs with dynamic ice sheet model runs. [BFB]

…s-change EAMxx: refactor machine_specs.py file

Joseph H Kennedy and others added 5 commits July 13, 2019 12:23

Add an ne30 grid for ice sheet simulations

854c190

Update surface mappings and glc input data

a16a651

Now, the mapping files, land surface data, land topography, and glacier mask files are all compatible. I was able to sucessfully run 10 years w/ MALI

Add a combined AIS GIS MALI model grid definition

282c70b

Update coupler and mali buildnml for AIS+GIS grid

cee500f

Add ne30_oECv3wLI_aisgis for cryosphere runs

23d817e

jhkennedy added mpas-albany-landice Land Coupled Model CIME labels Jul 13, 2019

jhkennedy added this to the v2.0alpha milestone Jul 13, 2019

jhkennedy requested review from matthewhoffman, jgfouca and jonbob July 13, 2019 21:10

jhkennedy assigned jonbob Jul 13, 2019

jhkennedy commented Jul 13, 2019

View reviewed changes

components/clm/bld/namelist_files/namelist_defaults_clm4_5.xml Show resolved Hide resolved

jgfouca approved these changes Jul 15, 2019

View reviewed changes

matthewhoffman reviewed Jul 16, 2019

View reviewed changes

cime/config/e3sm/config_grids.xml Show resolved Hide resolved

cime/config/e3sm/config_grids.xml Outdated Show resolved Hide resolved

cime/config/e3sm/config_grids.xml Outdated Show resolved Hide resolved

Fix typos: LND->OCN

d138092

Update MALI aisgis20km grid mapping files and default clm4.5 fsurdat

ad53016

jhkennedy requested a review from matthewhoffman August 7, 2019 15:00

matthewhoffman approved these changes Aug 7, 2019

View reviewed changes

jonbob requested changes Aug 7, 2019

View reviewed changes

cime/config/e3sm/config_grids.xml Outdated Show resolved Hide resolved

Fix Typos in GLC-->oEC60to30v3wLI gridmap

ae468ac

jhkennedy requested a review from jonbob August 7, 2019 17:55

jonbob approved these changes Aug 7, 2019

View reviewed changes

jonbob merged commit ae468ac into master Aug 8, 2019

jonbob deleted the jhkennedy/ne30-glc branch August 8, 2019 16:40

jgfouca pushed a commit that referenced this pull request Nov 7, 2024

Merge pull request #3069 from E3SM-Project/bartgol/eamxx/machine-spec…

b3b462e

…s-change EAMxx: refactor machine_specs.py file

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new ne30 grids with active MALI #3069

Add new ne30 grids with active MALI #3069

jhkennedy commented Jul 13, 2019

matthewhoffman left a comment

jonbob commented Jul 25, 2019 •

edited

Loading

stephenprice commented Jul 25, 2019

jhkennedy commented Jul 25, 2019

jonbob commented Jul 25, 2019

matthewhoffman commented Jul 25, 2019 via email

mt5555 commented Jul 25, 2019

jonbob commented Jul 25, 2019

jonbob commented Jul 30, 2019

bishtgautam commented Jul 30, 2019 •

edited

Loading

bishtgautam commented Jul 30, 2019

jhkennedy commented Jul 31, 2019

jonbob commented Jul 31, 2019

matthewhoffman commented Jul 31, 2019

jhkennedy commented Jul 31, 2019

jhkennedy commented Aug 7, 2019

matthewhoffman commented Aug 7, 2019

jonbob commented Aug 7, 2019

jonbob commented Aug 8, 2019

Add new ne30 grids with active MALI #3069

Add new ne30 grids with active MALI #3069

Conversation

jhkennedy commented Jul 13, 2019

matthewhoffman left a comment

Choose a reason for hiding this comment

jonbob commented Jul 25, 2019 • edited Loading

stephenprice commented Jul 25, 2019

jhkennedy commented Jul 25, 2019

jonbob commented Jul 25, 2019

matthewhoffman commented Jul 25, 2019 via email

mt5555 commented Jul 25, 2019

jonbob commented Jul 25, 2019

jonbob commented Jul 30, 2019

bishtgautam commented Jul 30, 2019 • edited Loading

bishtgautam commented Jul 30, 2019

jhkennedy commented Jul 31, 2019

jonbob commented Jul 31, 2019

matthewhoffman commented Jul 31, 2019

jhkennedy commented Jul 31, 2019

jhkennedy commented Aug 7, 2019

matthewhoffman commented Aug 7, 2019

jonbob commented Aug 7, 2019

jonbob commented Aug 8, 2019

jonbob commented Jul 25, 2019 •

edited

Loading

bishtgautam commented Jul 30, 2019 •

edited

Loading