Fix bug in setting gases above model top for RRTMGP #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in setting the gases above model top. We inteded to copy the top-most model level into the extra level above the model top, but instead we accidentally copied the *second* model level.
|
Differences in solar and longwave heating from a 1-month simulation with ne4, with and without the fix (zonal mean profiles): |
|
The change looks good. @singhbalwinder , can you take a quick look and approve if you see no problem? Thanks. |
wlin7
added a commit
that referenced
this pull request
Aug 14, 2019
Fix bug in setting gases above model top for RRTMGP Fix bug in setting the gases above model top. An extra level is added above the model top in the radiation code to handle heating between the top of the model and the top of the atmosphere. The code in question here was supposed to copy the gases from the top-most model level into the extra level above the model top, but instead we accidentally copied the second model level. [non-BFB] only for the RRTMGP tests.
|
Merged to next. |
wlin7
added a commit
that referenced
this pull request
Aug 15, 2019
Fix bug in setting gases above model top for RRTMGP Fix bug in setting the gases above model top. An extra level is added above the model top in the radiation code to handle heating between the top of the model and the top of the atmosphere. The code in question here was supposed to copy the gases from the top-most model level into the extra level above the model top, but instead we accidentally copied the second model level. [non-BFB] only for the RRTMGP tests.
|
Merged to master. Request to bless RRTMGP test for sandiatoss3. |
jgfouca
pushed a commit
that referenced
this pull request
Nov 7, 2024
…r_layout_w_horiz_remap Fixes a bug when copying grid data for a geo data of scalar type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in setting the gases above model top. An extra level is added above the model top in the radiation code to handle heating between the top of the model and the top of the atmosphere. The code in question here was supposed to copy the gases from the top-most model level into the extra level above the model top, but instead we accidentally copied the second model level.
[non-BFB] only for the RRTMGP tests.