Update mpas-ocean to capture edge fluxes #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
771d054 to
db8823e
Compare
|
@vanroekel take a look to make sure this includes what you want. I am running some tests now. |
|
passes: But failed these: on cori-knl. Most likely not due to this PR, but I'd need to compare |
|
@mark-petersen - those tests are failing because we also need the fix from PR #2769 |
|
@jonbob I added those two previous bug fixes. Thanks for pointing those out. I now have: Much better! I'm still getting: Looking into that now... |
|
This branch is not passing threading tests. I am checking on the maint-1.0 branch now. |
|
The current maint-1.0 branch also fails those PET tests (hash 9fc77cb). The good news is that this PR is ready to merge. I'll make an issue for maint-1.0. |
|
@vanroekel is out today. I'm removing him and adding me as reviewer. |
|
Reported PET problem at #3062. I was mistaken, I can't add myself as a reviewer. |
|
Is @jonbob also out today? He's the assigned integrator. I could merge it. |
|
So does this PR fix all the PET tests on maint-1.0? Or 3 still fail? |
|
@rljacob - I'm back and can take this back, if you need. I'm seeing the same PET failures on anvil, but I also tested current master and it has the same issue. |
|
Does this PR fix #3062 ? |
|
Yes go ahead. |
|
merged to maint-1.0 |
rljacob
pushed a commit
that referenced
this pull request
Apr 21, 2021
…9-03-29 Jgfouca/branch for acme split 2019 03 29 Change list: Features: Implements remaining changes for gustiness feature for EAMv2 Support multiqueueing for sandiatoss3 Add a new 'B' test option to indicate a build-only test Bug fixes: Remove dependence on "mask" variables in the mapping files that are input to the gen_domain tool. Fix some issues with downloading input files when checksum files are not set up Fix kokkos build, Make logic needs to happen after macro include or else kokkos flags are lost CIME fixes for PIO2 Use consistent casing (all-caps) for build_threaded value Test suite: scripts-regression-tests Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review: @jedwards4b
rljacob
pushed a commit
that referenced
this pull request
May 6, 2021
…9-03-29 Jgfouca/branch for acme split 2019 03 29 Change list: Features: Implements remaining changes for gustiness feature for EAMv2 Support multiqueueing for sandiatoss3 Add a new 'B' test option to indicate a build-only test Bug fixes: Remove dependence on "mask" variables in the mapping files that are input to the gen_domain tool. Fix some issues with downloading input files when checksum files are not set up Fix kokkos build, Make logic needs to happen after macro include or else kokkos flags are lost CIME fixes for PIO2 Use consistent casing (all-caps) for build_threaded value Test suite: scripts-regression-tests Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review: @jedwards4b
jgfouca
pushed a commit
that referenced
this pull request
Nov 7, 2024
…_markdown Automatically Merged using E3SM Pull Request AutoTester PR Title: change RRM docs to point from scream-docs to eamxx-scripts PR Author: bogensch PR LABELS: AT: AUTOMERGE, documentation, AT: Integrate Without Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is identical to #2760, but for maint-1.0. It adds variables within tracer_advection_mono to capture the edge based fluxes of temperature and salinity to fully close the heat and salinity budgets regionally.
[BFB]