Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for performance archiving on Compy #2943

Merged
merged 1 commit into from
May 30, 2019

Conversation

worleyph
Copy link
Contributor

Added logic for compy to provenance.py, specified
the location of the performance archive in the
compy entry in config_machines.xml (enabled for
all projects) and added the job progress monitoring
script syslog.compy. Also removed performance
archiving support for edison, now that it has been
decommissioned.

[BFB] - Bit-For-Bit

Added logic for compy to provenance.py, specified
the location of the performance archive in the
compy entry in config_machines.xml (enabled for
all projects) and added the job progress monitoring
script syslog.compy. Also removed performance
archiving support for edison, now that it has been
decommissioned.

[BFB] - Bit-For-Bit
@worleyph
Copy link
Contributor Author

@rljacob , please reassign reviewers and integrator as appropriate. Thanks.

Copy link
Member

@sarats sarats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks right. Someone else with token can test on Compy.

Since /compyfs is the the top level SAVE_TIMING_DIR, I presume 'performance_archive' will be created under that.

Just a clarification: Is that path limited to e3sm project only? If not, it's probably better to have e3sm specific suffix to differentiate from other BER projects if we have shared access.

@sarats
Copy link
Member

sarats commented May 24, 2019

Hmm... I see that /compyfs (without e3sm suffix) is being used everywhere in the machine file. So, perhaps that's not a concern. Default permissions enable group write to performance_archive. So, it's fine as long as non-E3SM users can't meddle with it.

@worleyph
Copy link
Contributor Author

So, it's fine as long as non-E3SM users can't meddle with it.

What is your concern? Vandalism of some sort? Shouldn't be anything sensitive or critical being written to the performance archive.

@sarats
Copy link
Member

sarats commented May 24, 2019

I was just thinking of accidental deletes and thought /compfs/performance_archive may not convey that it's related to e3sm.

I'm used to our project specific directories at the LCFs. Anyway, I see /compyfs used everywhere in the machine file. So, this is not a problem.

@worleyph
Copy link
Contributor Author

worleyph commented May 24, 2019

@sarats , thanks for asking about this. This is a BER system, and the accounts (once we start using them consistently) will allow us to differentiate between jobs in the performance archive. For example, at NERSC all supported projects (acme, m2830, m2833) archive in the same location. This isn't supported at the OLCF because of the directory permissions policies for proj-shared.

@worleyph
Copy link
Contributor Author

Would be nice to get this intergrated before people jump on and start using the system. @singhbalwinder and @bibiraju , could you please do quick reviews (or ask to be unassigned)? Thanks.

Copy link
Contributor

@singhbalwinder singhbalwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay. Everything looks great!

@worleyph
Copy link
Contributor Author

Thanks @bibiraju , @singhbalwinder , and @sarats . This is ready to go @jgfouca .

@rljacob rljacob assigned bibiraju and unassigned jgfouca May 29, 2019
@rljacob
Copy link
Member

rljacob commented May 29, 2019

Reassigning this to @bibiraju since its Compy related and JimF is pretty busy.

bibiraju pushed a commit that referenced this pull request May 30, 2019
Add support for performance archiving on Compy #2943

Added logic for compy to provenance.py, specified
the location of the performance archive in the
compy entry in config_machines.xml (enabled for
all projects) and added the job progress monitoring
script syslog.compy. Also removed performance
archiving support for edison, now that it has been
decommissioned.

[BFB] - Bit-For-Bit
@bibiraju bibiraju merged commit bec2df0 into master May 30, 2019
bibiraju added a commit that referenced this pull request May 30, 2019
Add support for performance archiving on Compy #2943

Added logic for compy to provenance.py, specified
the location of the performance archive in the
compy entry in config_machines.xml (enabled for
all projects) and added the job progress monitoring
script syslog.compy. Also removed performance
archiving support for edison, now that it has been
decommissioned.

[BFB] - Bit-For-Bit
@rljacob rljacob deleted the worleyph/cime/compy_perf_arch branch June 19, 2019 04:06
jgfouca pushed a commit that referenced this pull request Jun 25, 2019
Add support for performance archiving on Compy #2943

Added logic for compy to provenance.py, specified
the location of the performance archive in the
compy entry in config_machines.xml (enabled for
all projects) and added the job progress monitoring
script syslog.compy. Also removed performance
archiving support for edison, now that it has been
decommissioned.

[BFB] - Bit-For-Bit
jgfouca pushed a commit that referenced this pull request Oct 9, 2024
Automatically Merged using E3SM Pull Request AutoTester
PR Title: Frontier: disable hipInit before MPI_Init
PR Author: dqwu
PR LABELS: cmake, AT: AUTOMERGE, AT: Integrate Without Testing, Frontier
brhillman pushed a commit that referenced this pull request Dec 5, 2024
Automatically Merged using E3SM Pull Request AutoTester
PR Title: Frontier: disable hipInit before MPI_Init
PR Author: dqwu
PR LABELS: cmake, AT: AUTOMERGE, AT: Integrate Without Testing, Frontier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants