Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress pio logs on non-component-root processes #2840

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

jayeshkrishna
Copy link
Contributor

Making sure that we print out PIO logs only from rank 0 of each
component.

This bug was introduced in PR #2799.

Fixes #2839

[BFB]

Fixing a bug that was introduced in PR #2799 (commit :
3eebd7f ).

Making sure that we print out PIO logs only from rank 0 of each
component. The old code printed out logs from all ranks in each
component, resulting in large log files.

Fixes #2839
@jayeshkrishna jayeshkrishna self-assigned this Apr 5, 2019
@jayeshkrishna jayeshkrishna requested review from jgfouca and dqwu April 5, 2019 15:21
Copy link
Contributor

@dqwu dqwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.
Note, the output from the root process will be in cpl.log (not e3sm.log).

@dqwu
Copy link
Contributor

dqwu commented Apr 5, 2019

@jgfouca
It is confirmed that shr_log_unit is redirected to cpl.log for rank 0.
For other ranks, it is redirected to e3sm.log.
Not sure if it was designed that way in CIME: cpl log instead of e3sm log.

@worleyph
Copy link
Contributor

worleyph commented Apr 5, 2019

@dqwu , prior to the CIME update, PIO output of this sort went both to cpl.log:

  CPL              : pio_numiotasks =            8
  CPL              : pio_stride =           16
  CPL              : pio_root =            0
  CPL              : pio_iotype =            5
 
  OCN              : pio_numiotasks =            8
  OCN              : pio_stride =           16
  OCN              : pio_root =            0
  OCN              : pio_iotype =            5
 
  ICE              : pio_numiotasks =            8
  ICE              : pio_stride =           16
  ICE              : pio_root =            0
  ICE              : pio_iotype =            5
 
  ROF              : pio_numiotasks =            8
  ROF              : pio_stride =           16
  ROF              : pio_root =            0
  ROF              : pio_iotype =            5

and to e3sm.log:

  ATM              : pio_numiotasks =           42
  ATM              : pio_stride =           16
  ATM              : pio_root =            0
  ATM              : pio_iotype =            5
 
  LND              : pio_numiotasks =           43
  LND              : pio_stride =           16
  LND              : pio_root =            0
  LND              : pio_iotype =            5
 
  GLC              : pio_numiotasks =            1
  GLC              : pio_stride =            1
  GLC              : pio_root =            0
  GLC              : pio_iotype =            5
 
  WAV              : pio_numiotasks =            1
  WAV              : pio_stride =            1
  WAV              : pio_root =            0
  WAV              : pio_iotype =            5

  ESP              : pio_numiotasks =            1
  ESP              : pio_stride =            1
  ESP              : pio_root =            0
  ESP              : pio_iotype =            6

For some reason, the above information was output twice in each log file.

@worleyph
Copy link
Contributor

worleyph commented Apr 5, 2019

@dqwu , our posts crossed :-). Your post explains why some go to one log file and the rest go to the other log file.

@jgfouca
Copy link
Member

jgfouca commented Apr 5, 2019

Thanks @jayeshkrishna !

jayeshkrishna added a commit that referenced this pull request Apr 5, 2019
…2840)

Making sure that we print out PIO logs only from rank 0 of each
component.

This bug was introduced in PR #2799.

Fixes #2839

[BFB]

* jayeshkrishna/suppress_pio_non_root_msgs:
  Suppress pio logs on non-component-root processes
@jayeshkrishna jayeshkrishna merged commit a4d85f3 into master Apr 10, 2019
jgfouca pushed a commit that referenced this pull request Jun 25, 2019
…_non_root_msgs

Making sure that we print out PIO logs only from rank 0 of each
component.

This bug was introduced in PR #2799.

Fixes #2839

[BFB]
jgfouca pushed a commit that referenced this pull request Jun 26, 2024
…-adding-geodata-to-grid

Automatically Merged using E3SM Pull Request AutoTester
PR Title: Allow adding geo fields to grid objects, even if they are const
PR Author: bartgol
PR LABELS: infrastructure, BFB, radiation, AT: AUTOMERGE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB bug fix PR CIME PIO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants