Minor clean-up namelists to match new versions of mpas components #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last commit removes unused variables pointed out in #1151. |
mark-petersen
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
Passes
PET_Ln9.T62_oQU240.GMPAS-IAF.cori-knl_intel
ERS_Ld3.T62_oEC60to30v3.GMPAS-IAF.cori-knl_intel
ERS_Ld3.T62_oEC60to30v3.GMPAS-IAF.cori-knl_gnu
with a few typo fixes I just committed.
@vanroekel you can test from here now.
|
This last commit passes: |
|
?good to go then? I'm at a coffeeshop in New Orleans and am happy to hang out and push it...
…________________________________
From: Mark Petersen <notifications@github.com>
Sent: Wednesday, October 25, 2017 11:36 AM
To: ACME-Climate/ACME
Cc: Wolfe, Jonathan David; Assign
Subject: Re: [ACME-Climate/ACME] Minor clean-up namelists to match new versions of mpas components (#1862)
This last commit passes:
PET_Ln9.T62_oQU240.GMPAS-IAF.cori-knl_gnu
PET_Ln9.T62_oQU240.GMPAS-IAF.cori-knl_intel
ERS_Ld3.T62_oQU240.GMPAS-IAF.cori-knl_gnu
PET_Ln9.T62_oQU240.GMPAS-IAF.theta_intel
-
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#1862 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANDQcLrmV7B4GXwjqXh36dtGSLAEVHmWks5sv3GqgaJpZM4QDar5>.
|
jonbob
added a commit
that referenced
this pull request
Oct 25, 2017
Minor clean-up namelists to match new versions of mpas components This PR pulls together some minor script clean-ups that go along with the recent mpas update in PR #1823. There are some minor but necessary namelist and streams improvements. Tested with: * PET_Ln9.T62_oQU240.GMPAS-IAF.cori-knl_gnu * PET_Ln9.T62_oQU240.GMPAS-IAF.cori-knl_intel * ERS_Ld3.T62_oQU240.GMPAS-IAF.cori-knl_gnu * PET_Ln9.T62_oQU240.GMPAS-IAF.theta_intel [BFB] [NML]
|
merged to next |
|
@jonbob it looks like I will need to change the MOC compute interval. Can I do that here? Or should I do another PR? |
This fully enables the MOC AM for particular MPAS grid resolutions. The init part of the namelist is also removed as it is never used.
|
Last commit passes: |
|
Last commit passes: Does not pass a PET B case on cori or theta with Intel. This is not this PR, it is the same issue reported in #1850. |
vanroekel
approved these changes
Oct 30, 2017
jonbob
added a commit
that referenced
this pull request
Oct 31, 2017
Re-merging to include more developer updates [NML] [BFB]
|
re-merged to next |
jonbob
added a commit
that referenced
this pull request
Nov 1, 2017
Minor clean-up namelists to match new versions of mpas components This PR pulls together some minor script clean-ups that go along with the recent mpas update in PR #1823. There are some minor but necessary namelist and streams improvements. Tested with: * PET_Ln9.T62_oQU240.GMPAS-IAF.cori-knl_gnu * PET_Ln9.T62_oQU240.GMPAS-IAF.cori-knl_intel * ERS_Ld3.T62_oQU240.GMPAS-IAF.cori-knl_gnu * PET_Ln9.T62_oQU240.GMPAS-IAF.theta_intel [BFB] [NML]
|
merged to master |
jgfouca
pushed a commit
that referenced
this pull request
Nov 10, 2017
Convert SEQ to use compare-two Test suite: code_checker, seq by-hand and with re-run Test baseline: Test namelist changes: Test status: bit for bit Fixes #1862 User interface changes?: N Update gh-pages html (Y/N)?: N Code review: @jedwards4b @billsacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls together some minor script clean-ups that go along with the recent mpas update in PR #1823. There are some minor necessary namelist and streams improvements.
Do Not Merge - waiting for more streams changes
[BFB]
[NML]