Module and threading updates for Theta #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amametjanov
commented
Oct 3, 2017
| if not self._is_env_loaded: | ||
| def load_env(self, reset=False): | ||
| if not self._is_env_loaded or reset: | ||
| os.environ["OMP_NUM_THREADS"] = str(self.thread_count) |
There was a problem hiding this comment.
@jgfouca OMP_NUM_THREADS is not being properly reset when switching between runs of tests with multiple case-dirs. For example, with PET test OMP_NUM_THREADS remains at 1 at first run's case.submit.
Also, this moves the 4-line block's assignment at https://github.com/ACME-Climate/ACME/blob/master/cime/scripts/lib/CIME/case_run.py#L86 to happen earlier (so that it can be captured in logs/run_environment.txt).
jgfouca
approved these changes
Oct 3, 2017
amametjanov
added a commit
that referenced
this pull request
Oct 3, 2017
Module and threading updates for Theta: * Add a default 64x1 PE layout * Update Depends.intel file * Update Theta modules * Add option to use pre-built MPAS tools * Reload env for tests with multiple case-dirs [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Oct 3, 2017
Fix SEQ test on skybridge. Without this change, skybridge was trying to run this on a single node: mpiexec --np 16 ppr=5 ... With the PPR lowered to 5 due to the ROOTPE changes, but the --np not adjusted, the node could not accomodate this request. After this change, it runs: mpiexec --np 9 ppr=5 ... Test suite: ./create_test SEQ_Ln9.f19_g16_rx1.A Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: N Update gh-pages html (Y/N)?: Code review: @jedwards4b
amametjanov
added a commit
that referenced
this pull request
Oct 6, 2017
Re-merge the PR to bring the new commit. [BFB]
amametjanov
added a commit
that referenced
this pull request
Oct 6, 2017
Module and threading updates for Theta: * Add a default 64x1 PE layout * Update Depends.intel file * Update Theta modules * Add option to use pre-built MPAS tools * Reload env for tests with multiple case-dirs [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Oct 25, 2017
Module and threading updates for Theta: * Add a default 64x1 PE layout * Update Depends.intel file * Update Theta modules * Add option to use pre-built MPAS tools * Reload env for tests with multiple case-dirs [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Feb 27, 2018
Module and threading updates for Theta: * Add a default 64x1 PE layout * Update Depends.intel file * Update Theta modules * Add option to use pre-built MPAS tools * Reload env for tests with multiple case-dirs [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Mar 14, 2018
Module and threading updates for Theta: * Add a default 64x1 PE layout * Update Depends.intel file * Update Theta modules * Add option to use pre-built MPAS tools * Reload env for tests with multiple case-dirs [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module and threading updates for Theta:
[BFB]