Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the settings of pgi compiler on Titan #1768

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

minxu74
Copy link
Contributor

@minxu74 minxu74 commented Sep 6, 2017

This is a part of PR #1767 submitted by Pat Worley, focusing on the
changes of the settings of pgi compiler in Titan.

As stated in PR #1767:
"Changes including removing the dependence on the version of pgi/17.5.0
installed in Dave Norton's directories, moving instead
to the now official OLCF installation. Also fixed a typo in the
module switch command for the PGI version used with PGIACC, and
changed the 'pin' flag to 'pinned' for PGIACC, as 'pin' is no
longer legal."

[BFB]

This is a part of PR #1767 submitted by Pat Worley, focusing on the
changes of the settings of pgi compiler in Titan.

As stated in PR #1767:
"Changes including removing the dependence on the version of pgi/17.5.0
installed in Dave Norton's directories, moving instead
to the now official OLCF installation. Also fixed a typo in the
module switch command for the PGI version used with PGIACC, and
changed the 'pin' flag to 'pinned' for PGIACC, as 'pin' is no
longer legal."

[Non-BFB] - Non Bit-For-Bit
@worleyph
Copy link
Contributor

worleyph commented Sep 6, 2017

@minxu74 , these changes should be BFB. The non-BFB aspect of PR #1767 is the change of the cpu-target for most of the code.

minxu74 added a commit that referenced this pull request Sep 6, 2017
This is a part of PR #1767 submitted by Pat Worley, focusing on the
changes of the settings of pgi compiler in Titan.

As stated in PR #1767:
"Changes including removing the dependence on the version of pgi/17.5.0
installed in Dave Norton's directories, moving instead
to the now official OLCF installation. Also fixed a typo in the
module switch command for the PGI version used with PGIACC, and
changed the 'pin' flag to 'pinned' for PGIACC, as 'pin' is no
longer legal."

[Non-BFB]
* minxu74/titan/fix-pgi-compiler:
  Fixed the settings of pgi compiler on Titan
@minxu74
Copy link
Contributor Author

minxu74 commented Sep 6, 2017

@worleyph Since the compiler was changed, I took it granted that the result was non-BFB. I will correct it here and in the merge message to master later.

@worleyph
Copy link
Contributor

worleyph commented Sep 6, 2017

Compiler was changed from 17.5.lustre to 17.5.0 . I've been assuming that those are identical compiler versions, but I could be wrong. Can't really check now that 17.5.lustre is no longer available, unless you have baselines generated with 17.5.lustre.

@worleyph
Copy link
Contributor

worleyph commented Sep 6, 2017

I found two runs where one uses pgi/17.5.lustre and the other uses pgi/17.5.0 . This is MPI-only, but through 1 day (A_WCYCL ne30_oEC) the atm.log output are identical. Pretty safe to say that the compilers are effectively the same.

@minxu74
Copy link
Contributor Author

minxu74 commented Sep 6, 2017

@worleyph Great. Thanks a lot for the confirmation! I will change the tag to BFB in the merge message to master.

@minxu74 minxu74 merged commit d6d6c3a into master Sep 8, 2017
jgfouca pushed a commit that referenced this pull request Sep 15, 2017
…ve_misleading_text

Remove misleading text from the dependency string in config_batch.xml
Removes misleading text from the dependency string in config_batch.xml, as cime does not implement logical dependencies between jobs

Test suite: scripts_regression_tests (pending, but run with this change in another branch)
Test status: ok

User interface changes?: N

Update gh-pages html (Y/N)?: N

Code review: @jedwards4b
@minxu74 minxu74 deleted the minxu74/titan/fix-pgi-compiler branch January 26, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants