Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in CLM related to NaNs when using PGI on Titan. #176

Closed
wants to merge 1 commit into from

Conversation

bishtgautam
Copy link
Contributor

A B1850C5L45BGC and ICLM45BGC case ran successfully after this fix on Titan,
when compiled with PGI. This commit resolves #165.

[BFB]

@bishtgautam
Copy link
Contributor Author

I realized that I made fews mistakes in this PR and PR #174:

  • I created a branch from head rather than HASH that introduced the bug, and
  • The name of the branch doesn't follow the naming convention.

For both PRs, the starting HASH should have been b7663ce. How do I fix both PRs?

A B1850C5L45BGC and ICLM45BGC case ran successfully after this fix on Titan,
when compiled with PGI. This commit resolves #165.

[BFB]
@bishtgautam bishtgautam force-pushed the bishtgautam/lnd/bugfix-for-pgi branch from acb0fd4 to 87c99e3 Compare April 5, 2015 16:48
@bishtgautam bishtgautam closed this Apr 5, 2015
@bishtgautam bishtgautam deleted the bishtgautam/lnd/bugfix-for-pgi branch April 5, 2015 16:50
@bishtgautam
Copy link
Contributor Author

I was able to fix both the issues by the following commands

# 1) Rebase the branch from the correct starting hash
> git checkout bishtgautam/lnd/intel-14x-bugfix
# Determine the parent hash
> git log --pretty="%h %p" -n 1
830d81d cab58cf
# Change the parent of '830d81d' to be 'b7663ce' instead of 'cab58cf' 
> git rebase --onto b7663ce cab58cf
# Push the change in the remote
> git push origin bishtgautam/lnd/intel-14x-bugfix -f

# 2) Rename branch
> git branch -m bishtgautam/lnd/intel-14x-bugfix bishtgautam/lnd/bug-fix-intel-14x
> git push origin :bishtgautam/lnd/intel-14x-bugfix
> git push origin bishtgautam/lnd/bug-fix-intel-14x

Since the branches were deleted, the existing PRs were automatically deleted. I have created two new PRs.

mwarusz pushed a commit to mwarusz/E3SM that referenced this pull request Dec 5, 2024
fixes reading dimensions for Omega decomposition and unused dimensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calculation with NaN in CLM4_5 with PGI compiler on Titan
2 participants