Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new compiler options for cori-knl to make it easier for testing #1685

Closed
wants to merge 2 commits into from

Conversation

ndkeen
Copy link
Contributor

@ndkeen ndkeen commented Jul 28, 2017

For cori-knl only right now:
--compiler=intel18 to use the beta version of Intel v18
--compiler=intel-impi to use the Intel MPI (with the default Intel compiler)
[BFB]

ndkeen added 2 commits July 27, 2017 16:48
Add option to compile with intel18 beta version. --compiler=intel18
Add option to build with Intel MPI.  --compiler=intel-impi
To use Intel MPI, can't use Cray compiler wrappers and so need to add some flags manually
…ion 18 of Intel compiler) and the option to use Intel MPI
@ndkeen ndkeen self-assigned this Jul 28, 2017
ndkeen added a commit that referenced this pull request Jul 28, 2017
…(PR #1685)

Add two new compiler options for cori-knl to make it easier for testing

For cori-knl only right now:
--compiler=intel18 to use the beta version of Intel v18
--compiler=intel-impi to use the Intel MPI (with the default Intel compiler)
[BFB]
@worleyph
Copy link
Contributor

@ndkeen , would I be able to reproduce your seg. fault, reported elsewhere, by specifying intel-impi ? What compset and resolution should I use?

@ndkeen
Copy link
Contributor Author

ndkeen commented Jul 28, 2017

Yes. Would it make it easier if I pushed to master?
I do see failures with acme_dev tests with this using --compiler=intel-impi (and some with intel18). I'm working through them to see if they make sense, etc.

The results I reported before were with a different branch, but same idea -- probably would work the same, but I (or you) can try again now.

@worleyph
Copy link
Contributor

Would it make it easier if I pushed to master?

My "master" has lots of local changes, for the ATM initialization study. Checking out your branch is just as convenient for me. I would like to know exactly what case you ran when you observed this. If you want to repeat it first yourself, to verify that it is still there, that would be great.

@ndkeen
Copy link
Contributor Author

ndkeen commented Jul 29, 2017

@amametjanov wants me to revert and rework using the -mpilib flag.

@worleyph
Copy link
Contributor

@ndkeen , added code to check for NaNs and INFs in the data being passed to the reproducible sum routine. The case that is failing for you with the Intel MPI library is due to NaNs being passed to this routine. This of course does not address where the NaNs are coming from.

@rljacob rljacob requested a review from amametjanov August 3, 2017 16:52
@rljacob
Copy link
Member

rljacob commented Aug 3, 2017

@ndkeen how is this going?

@ndkeen
Copy link
Contributor Author

ndkeen commented Aug 3, 2017

I decided I will revert this change and create 2 new PR's: one to add --compiler=intel18 which I can do quickly, the other to add option for using Intel MPI using the --mpilib=impi option which may take some time. Related: I'm not sure how to revert my change which is on next. I know it's git revert, but not sure the args.

@rljacob
Copy link
Member

rljacob commented Aug 3, 2017

Find the merge commit that placed it on next, which is d963c03, and then do
git revert -m 1 d963c03

ndkeen added a commit that referenced this pull request Aug 3, 2017
…to next (PR #1685)"

This reverts commit d963c03, reversing
changes made to ef3387f.
@ndkeen ndkeen closed this Aug 16, 2017
@ndkeen
Copy link
Contributor Author

ndkeen commented Aug 16, 2017

Done differently here: #1710

@ndkeen ndkeen deleted the ndk/machinefiles/cori-knl-intelmpi-intel18b branch February 5, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants