-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RRM CONUS case configuration updates to reduce new user edits #168
Conversation
Two namelist parameters were not in build.namelist when the RRM case configuration was developeed. These additions allow the user to create an RRM case out-of-the-box without having to enter namelist values in the user_nl* files. On branch eroesler/ATM/RRM-meshfilefixer Changes to be committed: modified: build-namelist
These changes allow a user to build the variable resolution CONUS RRM ACME configuration out-of-the-box without having to specify the values for some physics paramterizations in the user_nl_* files. WARNING: As of this commit, the values have not been tuned for the CONUS grid but are values used to tune either the ne30 or armx8v3 grid. On branch eroesler/ATM/RRM-meshfilefixer Changes to be committed: modified: namelist_files/namelist_defaults_cam.xml
Three sets of changes in this commit. 1. The namelist_defaults_cam.xml and the namelist_mod.F90 have updates so that a user wanting to run RRM case does not have to specify the path of the grid file in the user_nl_cam. This will reduce potential error and improve ease of the RRM capability. It was found that the mesh_file designation needed to be blank for a structured (non-RRM) grid, so namelist_mod.F90 was altered to not have a model crash during runtime. 2. The paramter EPS_AAREA needed to be raised in env_run.xml by a factor of 10. This was done by hand every time an RRM case was built. The changes to config_grid.xml now have the correct value of EPS_AAREA to run RRM. 3. Final changes is to $PROJECT variable for SNL computers. On branch eroesler/ATM/RRM-meshfilefixer Changes to be committed: modified: ../models/atm/cam/bld/namelist_files/namelist_defaults_cam.xml modified: ../models/atm/cam/src/dynamics/se/share/namelist_mod.F90 modified: ccsm_utils/Case.template/config_grid.xml modified: ccsm_utils/Machines/mkbatch.redsky modified: ccsm_utils/Machines/mkbatch.skybridge
acme_developer on skybridge passed. |
Can you remove all those physics tunings from this pull request? For RRM grids, we should use the default values for all those parameters, unless somoene has taken the time to tune them. In particular, I think we should not set special values for the RRM grid for these parameters: soil_erod_file, dust_emis_fact, cldfrc_rhminl, cldfrc_dp1, zmconv_c0_lnd, zmconv_c0_ocn, zmconv_tau Also, I think there is a problem with zmconv_tau: this pull request looks like it might set a default value of 3000 for all simulations. I'm pretty sure this is supposed to be 3600, not 3000. |
Hi @mt5555, I'd like to take the time to tune those parameters for CONUS, and I'll fix the zmconv_tau. Thanks for catching that. |
The parameter zmconv_tau was incorrectly set to 3000. It is now set to 3600. On branch eroesler/ATM/RRM-meshfilefixer Changes to be committed: modified: ../models/atm/cam/bld/namelist_files/namelist_defaults_cam.xml
Ok then, I'll hold it. @eroesler, please let me know when it is ready. |
Default values will be used unless specified by the user. These parameters have been removed : soil_erod_file, dust_emis_fact, cldfrc_rhminl, cldfrc_dp1, zmconv_c0_lnd, zmconv_c0_ocn, zmconv_tau On branch eroesler/ATM/RRM-meshfilefixer Changes to be committed: modified: models/atm/cam/bld/namelist_files/namelist_defaults_cam.xml modified: models/atm/cam/src/dynamics/se/share/namelist_mod.F90 modified: scripts/ccsm_utils/Case.template/config_grid.xml
Forgot to delete comments for RRM grids in last commit, so fixed text in this commit. On branch eroesler/ATM/RRM-meshfilefixer Changes to be committed: modified: models/atm/cam/bld/namelist_files/namelist_defaults_cam.xml
Hi @yjinho and @mt5555 (and @susburrows), The settings for the tuning parameters are removed so that the RRM grid will now run with the defaults. I've retested with these changes and have rerun the acme_developer's tests, which all passed. The branch should be ready to be merged. |
Thanks @eroesler !! I'll get this moving. |
These additions allow the user to create the CONUS RRM case in a more out-of-the-box way without having to enter namelist values in the user_nl* files, the grid location, or edit env_run.xml. Two namelist parameters were not in build.namelist when the RRM case configuration for the CONUS grid was first developed and recently pushed to master. This update required a change to namelist_mod.F90 so that when using structured grids, a grid file is not needed. It should be noted that the tuning paramters (i.e. zmconv_tau, etc) have not been tuned for the CONUS grid but have been transferred from ne30 and armx8v3 configurations. Machine files for Sandia computers were also updated. The settings for the tuning parameters are removed so that the RRM grid will now run with the defaults. I've retested with these changes and have rerun the acme_developer's tests, which all passed. [NML] [AG-120] Conflicts: models/atm/cam/bld/namelist_files/namelist_defaults_cam.xml
It is now in next (done after midnight). So, I'll wait another day to see the tests and to merge this to master. |
It broke the tests. |
@@ -55,7 +55,7 @@ cat >! $file << EOF1 | |||
#=============================================================================== | |||
#SBATCH --job-name ${jobname} | |||
#SBATCH -N ${nodes} | |||
#SBATCH --account=${PROJECT} | |||
#SBATCH --account=FY${PROJECT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks a bunch of stuff
…and skybridge Broke the nightly testing since other scripts were not aware of this magic. Probably simpler to just always require the full project. [BFB]
This is the second merge to next for this PR. Problems were found in the nightly testing that needed to be fixed requiring additional commits on this branch. * eroesler/ATM/RRM-meshfilefixer: Remove automatic appending of FY to job submission account on redsky and skybridge
OK, the project issue has been fixed, added to this branch, and merged to next. |
Hi @yjinho, When do you think this branch will go to master? |
Hi @yjinho -- sounds good! Thanks! |
These additions allow the user to create the CONUS RRM case in a more out-of-the-box way without having to enter namelist values in the user_nl* files, the grid location, or edit env_run.xml. Two namelist parameters were not in build.namelist when the RRM case configuration for the CONUS grid was first developed and recently pushed to master. This update required a change to namelist_mod.F90 so that when using structured grids, a grid file is not needed. It should be noted that the tuning paramters (i.e. zmconv_tau, etc) have not been tuned for the CONUS grid but have been transferred from ne30 and armx8v3 configurations. Machine files for Sandia computers were also updated. The settings for the tuning parameters are removed so that the RRM grid will now run with the defaults. I've retested with these changes and have rerun the acme_developer's tests, which all passed. Also it fixes automatic appending of FY to job on redsky and skybridge. [BFB] [NML] [AG-120] Conflicts: models/atm/cam/bld/namelist_files/namelist_defaults_cam.xml
…-integration Pacer integration into Omega standalone driver
These additions allow the user to create the CONUS RRM case in a more out-of-the-box way without having to enter namelist values in the user_nl* files, the grid location, or edit env_run.xml. Two namelist parameters were not in build.namelist when the RRM case configuration for the CONUS grid was first developed and recently pushed to master. This update required a change to namelist_mod.F90 so that when using structured grids, a grid file is not needed.
It should be noted that the tuning paramters (i.e. zmconv_tau, etc) have not been tuned for the CONUS grid but have been transferred from ne30 and armx8v3 configurations.
Machine files for Sandia computers were also updated.
NML
AG-120