Fixes momentum flux in gustiness parameter #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug and its fix is found by Po-Lun Ma. The original code has a bug,which makes the gustiness effect on momentum flux smaller than what it should be. The effects of the bug on clouds and precipitation are small, but has an important effect on the westerly anomalies in tropical Pacific which is relevant to ENSO. The bug fix enhances the momentum flux in the tropics, weakening the prevailing easterlies so that the cold tongue won't extend too far into the west. The largest signal comes from TWP, so it might also improve WWB to help ENSO. [BFB] - Bit-For-Bit
polunma
approved these changes
Jul 10, 2017
|
A minor typo at line 285, it should be 0.00069444 m/s instead of mm/s, to avoid confusion. prec_gust from the cam convection is also in unit of m/s. |
|
Thanks @wlin7 . That is a good catch, I will fix it. |
[BFB] - Bit-For-Bit
|
merged to next |
wlin7
added a commit
that referenced
this pull request
Jul 12, 2017
Merge singhbalwinder/atm/gust-fix (PR #1624) This bug and its fix is found by Po-Lun Ma. The original code has a bug,which makes the gustiness effect on momentum flux smaller than what it should be. The effects of the bug on clouds and precipitation are small, but has an important effect on the westerly anomalies in tropical Pacific which is relevant to ENSO. The bug fix enhances the momentum flux in the tropics, weakening the prevailing easterlies so that the cold tongue won't extend too far into the west. The largest signal comes from TWP, so it might also improve WWB to help ENSO. [BFB] - Bit-For-Bit
jgfouca
pushed a commit
that referenced
this pull request
Oct 25, 2017
Merge singhbalwinder/atm/gust-fix (PR #1624) This bug and its fix is found by Po-Lun Ma. The original code has a bug,which makes the gustiness effect on momentum flux smaller than what it should be. The effects of the bug on clouds and precipitation are small, but has an important effect on the westerly anomalies in tropical Pacific which is relevant to ENSO. The bug fix enhances the momentum flux in the tropics, weakening the prevailing easterlies so that the cold tongue won't extend too far into the west. The largest signal comes from TWP, so it might also improve WWB to help ENSO. [BFB] - Bit-For-Bit
jgfouca
pushed a commit
that referenced
this pull request
Feb 27, 2018
Merge singhbalwinder/atm/gust-fix (PR #1624) This bug and its fix is found by Po-Lun Ma. The original code has a bug,which makes the gustiness effect on momentum flux smaller than what it should be. The effects of the bug on clouds and precipitation are small, but has an important effect on the westerly anomalies in tropical Pacific which is relevant to ENSO. The bug fix enhances the momentum flux in the tropics, weakening the prevailing easterlies so that the cold tongue won't extend too far into the west. The largest signal comes from TWP, so it might also improve WWB to help ENSO. [BFB] - Bit-For-Bit
jgfouca
pushed a commit
that referenced
this pull request
Mar 14, 2018
Merge singhbalwinder/atm/gust-fix (PR #1624) This bug and its fix is found by Po-Lun Ma. The original code has a bug,which makes the gustiness effect on momentum flux smaller than what it should be. The effects of the bug on clouds and precipitation are small, but has an important effect on the westerly anomalies in tropical Pacific which is relevant to ENSO. The bug fix enhances the momentum flux in the tropics, weakening the prevailing easterlies so that the cold tongue won't extend too far into the west. The largest signal comes from TWP, so it might also improve WWB to help ENSO. [BFB] - Bit-For-Bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug and its fix is found by Po-Lun Ma. The original code has a
bug,which makes the gustiness effect on momentum flux smaller than
what it should be. The effects of the bug on clouds and precipitation
are small, but has an important effect on the westerly anomalies in
tropical Pacific which is relevant to ENSO. The bug fix enhances the
momentum flux in the tropics, weakening the prevailing easterlies so
that the cold tongue won't extend too far into the west. The largest
signal comes from TWP, so it might also improve WWB to help ENSO.
[BFB] - Bit-For-Bit