Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade default PGI from 15.7 to 17.5 on Titan #1619

Merged
merged 1 commit into from
Jul 8, 2017

Conversation

minxu74
Copy link
Contributor

@minxu74 minxu74 commented Jul 7, 2017

The results of the acme developer test suite using PGI/17.5 on Titan
are exactly same as those reported in cdash using PGI/15.7. So the
default PGI version was upgraded from 15.7 to 17.5 on Titan.

[Non-BFB]

The results of the acme developer test suite using PGI/17.5 on Titan
are exactly same as those reported in cdash using PGI/15.7. So the
default PGI version was upgraded from 15.7 to 17.5 on Titan.

[Non-BFB]
@minxu74 minxu74 self-assigned this Jul 7, 2017
@minxu74 minxu74 added the Titan label Jul 7, 2017
@worleyph
Copy link
Contributor

worleyph commented Jul 7, 2017

@minxu74 and @mrnorman , I can understand changing the defaults to one of Dave Norton's local installations for pgiacc, but this is not officially supported by the OLCF. Will pgi/17.5.0 be an officially installed module "soon"? Can we wait until then? Pointing at Dave Norton's space has been fragile in the past.

@mrnorman
Copy link
Contributor

mrnorman commented Jul 7, 2017

Given that pgi/17.3 is already installed, I don't think it will be long, no. Plus, I've explicitly requested that it be installed on Titan. I agree that relying on Dave's installs can be fragile. We can wait to make it default for "pgi" until it's officially installed by OLCF if you want, but "pgiacc" should be set to 17.5 at least.

@worleyph
Copy link
Contributor

worleyph commented Jul 7, 2017

If it is imminent and if pgi/17.5.0 does not require commenting out the intent(in) on the pointer variables in the atmospheric physics, I'm fine with this PR. Will need to update it as soon as the official OLCF release is out.

@mrnorman
Copy link
Contributor

mrnorman commented Jul 7, 2017

Pat, that's a good point. 17.5 isn't supposed to require commenting out the intent(in) for those pointers. And 17.5 should come pretty quick.

@minxu74
Copy link
Contributor Author

minxu74 commented Jul 8, 2017

@worleyph and @mrnorman Thank you both for the useful discussions. Since it is necessary to upgrade to pgi/17.5 for PGIACC and the upgrade can also avoid changing source codes (commenting out the intent), I am going to merge the branch to master now. I will update it once the official version is released by OLCF.

@minxu74 minxu74 merged commit b0d992d into master Jul 8, 2017
minxu74 added a commit that referenced this pull request Jul 8, 2017
The results of the acme developer test suite using PGI/17.5 on Titan
are exactly same as those reported in cdash using PGI/15.7. So the
default PGI version was upgraded from 15.7 to 17.5 on Titan.

It is necessary to upgrade to pgi/17.5 for PGIACC and moreover the
upgrade can also avoid changing source codes (commenting out the
intent) required by the pgi version 16 and early versions of 17.

[Non-BFB]

* minxu74/titan/upgrade-default-pgi:
  Upgrade default PGI from 15.7 to 17.5 on Titan
@rljacob
Copy link
Member

rljacob commented Jul 8, 2017

@minxu74 did you merge this to next?

@minxu74
Copy link
Contributor Author

minxu74 commented Jul 9, 2017

@rljacob Yes. it was in next.

@rljacob
Copy link
Member

rljacob commented Jul 9, 2017

I see it now. Don't forget to add the PR # to the title. Then it will show up in the history here.
"Merge branch 'minxu74/titan/upgrade-default-pgi' into next (PR #1619)"

@minxu74 minxu74 deleted the minxu74/titan/upgrade-default-pgi branch July 26, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants