Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new --script-root option in CIME #1550

Merged
merged 1 commit into from
May 22, 2017

Conversation

mfdeakin-sandia
Copy link
Contributor

@mfdeakin-sandia mfdeakin-sandia commented May 22, 2017

CIME now fails if the CASE variable is changed after create_newcase is called; this change uses the new option in create_newcase to preserve the preferred directory structure and meet this requirement.

Closes #1388

@mfdeakin-sandia mfdeakin-sandia self-assigned this May 22, 2017
@mfdeakin-sandia
Copy link
Contributor Author

@PeterCaldwell @cameronsmith1 Sorry for the delay in fixing this; I've known something was wrong for a few days, but some of the Jenkins error messages were about failing to clone for some reason.

Copy link
Contributor

@cameronsmith1 cameronsmith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but these changes look fine to me.

@PeterCaldwell
Copy link
Contributor

I also haven't tested it but think this looks fine. @mfdeakin-sandia - I assume you have run run_acme with this change and confirmed it didn't crash?

@mfdeakin-sandia mfdeakin-sandia force-pushed the mfdeakin-sandia/run_acme/script_root_option branch from 31c8176 to 4812521 Compare May 22, 2017 22:33
@mfdeakin-sandia
Copy link
Contributor Author

Yes; I've verified that the model completes successfully and that run files are named correctly

@mfdeakin-sandia mfdeakin-sandia force-pushed the mfdeakin-sandia/run_acme/script_root_option branch from 4812521 to aa0717f Compare May 22, 2017 22:35
@mfdeakin-sandia mfdeakin-sandia merged commit aa0717f into master May 22, 2017
@mfdeakin-sandia mfdeakin-sandia deleted the mfdeakin-sandia/run_acme/script_root_option branch May 22, 2017 22:41
jgfouca pushed a commit that referenced this pull request Oct 25, 2017
Added new CAM-SE FVM grids and removed incorrect aliases

Cleaned up CAM-SE grid aliases in preparation for new CAM-SE dycore.
Added new grid aliases and domain files for new FVM physics grids using CAM-SE.

Test suite:

scripts_regression_test.py on Cheyenne.
Create setup a case for each CAM-SE grid alias (on Hobart)
prealpha test suite on Hobart
aquaplanet test case on Cheyenne
Test baseline: NA
Test namelist changes:
Test status: bit for bit

Fixes #1550

User interface changes?: All CAM-SE grid aliases for data ocean models require a mask.

Update gh-pages html (Y/N)?: N

Code review:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants