Coupler performance updates #1346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
amametjanov
commented
Mar 24, 2017
- Remove OpenMP parallel region overhead while querying num_threads
- Stop looping and exit array-contiguity-checking loop if there exists fragmentation
- Update vectorization and threading in m_AttrVect module
- Add threading to data-local sparse matrix-vector multiply
* !DIR$ CONCURRENT generates 'Unrecognized directive' warning. Replace
it with a more modern !DIR$ IVDEP that has the same meaning.
* Collapse two loops into one larger loop for faster threading.
* All !DIR$ CONCURRENT directives are replaced * Cleanup unused vars * Pull-up local variables
Also, the directive needs to be placed right before array assignment.
rljacob
requested changes
Mar 24, 2017
There was a problem hiding this comment.
Please make the MCT changes as a PR to https://github.com/MCSclimate/MCT and remove them from this PR. I'll bring in the MCT changes with the next subtree update (next week).
|
Any idea if this is BFB? |
|
Should be BFB. I was planning to check that with the A_WCYCL-compset after the latest MCT subtree update. SMS.ne4_Qu240.A_WCYCL2000 should be the smallest yet covering test, right? |
|
Right. |
|
Result of baseline comparisons before and after these changes is a PASS: |
|
Closing. Replaced by MCSclimate/MCT#47. |
|
The changes to cime/driver_cpl/shr/seq_comm_mct.F90 will need a separate PR. Lets make it an ACME one. |
|
Yes, let me bring that in with other updates. |
agsalin
pushed a commit
that referenced
this pull request
Apr 13, 2017
HOMME Improvement Homme needs to handle failures better so that useful info will still appear in TestStatus.log. Test suite: pylint Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: None Code review: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.