-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mpich bug and other Titan issues #1315
Conversation
Removing modules before we add them to ensure no errors happen.
Maybe we should merge this right away so that we can work on the combination of this branch and CIME5.2? |
tagging @jgfouca and @mfdeakin-sandia . changes needed to run on Titan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provided this, and it has been working for me. However, others were also having problems (with somewhat different symptoms) and it is unclear why this is even necessary, or whether it will break again in the future. That said, the current module load logic is not working and something needs to be done.
<environment_variables> | ||
set CESM_REPO = `./xmlquery CCSM_REPOTAG -value` | ||
if($status == 0) then | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, i see that its commenting out this setting in xml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compare to the original code, and look at the final product, not just the diff. I just prettied up the indentation. I did not delete the commented out lines because I did not know why they were there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also left off
1541 + <environment_variables>
in the above snippet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github's code discussion feature will let you start a conversation on any one line of code. But just one.
Can this be merged so we can make some progress on titan? |
If you can verify it helps, go ahead. |
Yes, I make it past the setup phase now. |
Fix mpich bug and other Titan issues Update the modules for Titan. Set CESM_REPO from the CESM_REPOTAG. Fixes #1279 [BFB] * mrnorman/titan-machine/fix-mpich-bug: Pat's config file that fixed runtime issues. Fixing Module issues on titan
User compset Fixes an issue with --user-compset flag, modifies test to include this Test suite: scripts_regression_tests.py user-compset tests Test baseline: Test namelist changes: Test status: bit for bit Fixes #1315 User interface changes?: Code review: @billsacks @jgfouca
Update the modules for Titan.
Comment out setting of CESM_REPO.
Fixes #1279