Split seaSurfacePressure into atmosphericPressure and seaIcePressure #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is non-bfb, and matches the MPAS-O PR |
|
@mark-petersen - can we just include this in my branch for the ssh tilt? |
|
I merged this one into #1278 |
agsalin
pushed a commit
that referenced
this pull request
Apr 13, 2017
Better content in TestStatus.log file.
There is no reason to print a full stacktrace when the model
fails. That just clutters the log file and provides no debugging value.
In some cases, create_test was losing stderr output. Now we redirect
stderr to stdout so it's never lost.
In some cases, the TestStatus claimed the RUN phase both passed
and failed. What actually happened was that the submit passed and the
run failed. The situation is now more clear.
Test suite: scripts-regression-tests --fast
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1291
User interface changes?: Improved formatting/content of TestStatus.log
Code review: @jedwards4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, MPAS-O only used the variable seaSurfacePressure, which was the sum of atmospheric and sea ice pressure at the top of layer 1. We need these variables separately, so we are splitting it into two variables.