Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPAS Makefile.in incompatibilities with CIME 5.2 #1282

Closed
wants to merge 1 commit into from

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Feb 22, 2017

This PR brings in new MPAS submodules that contain requested changes to the MPAS Makefile.in.ACME and Makefile.in.CESM from ACME-Climate/MPAS PR's #8, #9, and #10. Because this changes use CIME5.2 syntax, they are incompatible with the current CIME5 implementation -- so they are untested. Also brings in a new version of the MPAS framework that includes a fix to MPAS fillvalue when using PIO2 (MPAS-Dev PR 1211).
Fixes #1160

[BFB]

@rljacob
Copy link
Member

rljacob commented Feb 22, 2017

Instead of a separate PR, can you add these changes to the existing rljacob/update-cime5.2 branch for PR #1261 ?

@jonbob
Copy link
Contributor Author

jonbob commented Feb 22, 2017

Sure, but it will be tomorrow morning.

@jonbob
Copy link
Contributor Author

jonbob commented Feb 23, 2017

@rljacob - OK, I pushed these changes to your branch instead. Could you please check that it's OK?

@jonbob
Copy link
Contributor Author

jonbob commented Feb 27, 2017

Moved to the rljacob/update-cime5.2 branch instead of this separate PR

@jonbob jonbob closed this Feb 27, 2017
@jonbob jonbob deleted the jonbob/mpas/update-for-CIME52 branch February 27, 2017 16:49
agsalin pushed a commit that referenced this pull request Apr 13, 2017
Allow a custom input root through create_test.
Also, change check_input_data so that it supports custom input roots.

Test suite: by-hand, code-checker
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1282 (sort of)

User interface changes?: Add --input-dir argument to create_test

Code review: @jedwards4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix fillvalue usage in MPAS
2 participants