Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing an unused pio module #1228

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Conversation

jayeshkrishna
Copy link
Contributor

@jayeshkrishna jayeshkrishna commented Jan 18, 2017

This is an obsolete PIO1 module that is no longer used. This
module is also no longer available with PIO2. Removing it.

[BFB]

This is an obsolete PIO1 module that is no longer used. This
module is also no longer available with PIO2. Removing it.
jayeshkrishna added a commit that referenced this pull request Jan 18, 2017
This is an obsolete PIO1 module that is no longer used. This
module is also no longer available with PIO2. Removing it.

[BFB]
@jayeshkrishna
Copy link
Contributor Author

This change was tested by building the case below,

 ./create_newcase -case test_rem_unused_pio_mod_next -compset FC5 -res ne30_ne30

on compute001 (the modified file sat_hist.F90 is built in this case)

@jayeshkrishna jayeshkrishna merged commit 077f848 into master Jan 19, 2017
jayeshkrishna added a commit that referenced this pull request Jan 19, 2017
This is an obsolete PIO1 module that is no longer used. This
module is also no longer available with PIO2. Removing it.

[BFB]
@jayeshkrishna
Copy link
Contributor Author

Tested locally after merging to master using the case above. The nightlies on melvin also look good.

agsalin pushed a commit that referenced this pull request Apr 13, 2017
Add gx1v7
Adds support for gx1v7 grids for cesm. In gx1v7 (1 degree ocean) the Caspian is removed from the ocean domain and added to the land domain.

Test suite: regression testing passed
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?: Added new aliases for resolutions supporting a gx1v7 mask (Caspian in land domain). In addition to adding a gx1v7 version of existing gx1v6 grid aliases, I also added new aliases with a mask acronym in cases where the ocean mask was undefined. For example the resolution f09_f09 has an implicit gx1v6 mask but I added two new aliases making the mask explicit.
f09_f09_mg16
f09_f09_mg17
I also added the new mapping and domain files for gx1v7.
Eventually we may deprecate the aliases with undefined ocean masks but for now I left the implicit gx1v6 versions for backwards compatibility.

Code review: Jim and Mariana
@jayeshkrishna jayeshkrishna deleted the jayeshkrishna/rem_unused_pio_mod branch January 26, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants