Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELM Carbon mass balance error when use_pheno_flux_limiter=.true. #3256

Closed
jinyuntang opened this issue Oct 24, 2019 · 0 comments · Fixed by #3257
Closed

ELM Carbon mass balance error when use_pheno_flux_limiter=.true. #3256

jinyuntang opened this issue Oct 24, 2019 · 0 comments · Fixed by #3257
Assignees
@jinyuntang
Labels
bug Land

Comments

@jinyuntang
Copy link
Contributor

When use_pheno_flux_limiter=.true., land model fails with carbon mass balance error. A fix is under testing.
@jinyuntang jinyuntang self-assigned this Oct 24, 2019
@jinyuntang jinyuntang changed the title Carbon mass balance error when use_pheno_flux_limiter=.true. ELM Carbon mass balance error when use_pheno_flux_limiter=.true. Oct 24, 2019
@jinyuntang jinyuntang mentioned this issue Oct 24, 2019
Merged
bishtgautam added a commit that referenced this issue Oct 30, 2019
@bishtgautam
Merge branch 'jinyuntang/lnd/c_inbal_fix' into next (PR #3257)
ec93239 
For ELM, when use_pheno_flux_limiter=.true., the components
of maintance respiration are updated to avoid negative carbon
state variables. However, the total maintenance respiration
is not updated accordingly, causing an overesimation of total
maintenance respiration mr. Now this bug is fixed by ensuring
maintenance respiration is always recalculated by summing up
its components.

[BFB] when use_pheno_flux_limiter=.false.

Fixes #3256
bishtgautam added a commit that referenced this issue Feb 20, 2020
@bishtgautam
Merge branch 'jinyuntang/lnd/c_inbal_fix' into next (PR #3257)
2ef5ed2 
For ELM, when use_pheno_flux_limiter=.true., the components
of maintance respiration are updated to avoid negative carbon
state variables. However, the total maintenance respiration
is not updated accordingly, causing an overesimation of total
maintenance respiration mr. Now this bug is fixed by ensuring
maintenance respiration is always recalculated by summing up
its components.

[non-BFB] due to very tiny value changes.

Fixes #3256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinyuntang jinyuntang

Labels
bug Land
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inconsistency in c12 maintenance respiration calculation E3SM-Project/E3SM
1 participant
@jinyuntang