Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkpoint timing files named cesm_timing, not model_timing #2264

Closed
worleyph opened this issue Apr 6, 2018 · 3 comments · Fixed by #2266
Closed

checkpoint timing files named cesm_timing, not model_timing #2264

worleyph opened this issue Apr 6, 2018 · 3 comments · Fixed by #2266
Assignees
@rljacob
Labels
bug CIME

Comments

@worleyph
Copy link
Contributor

worleyph commented Apr 6, 2018

The raw timing data have the end-of-run timing files named

model_timing.<procid>

However, the checkpoint timing files, in timing/checkpoints, are named

cesm_timing_<simulation_date_and_time>.<procid>

This error was introduced in E3SM in a CIME update on September 5, in which the command in cime_comp_mod.F90 was updated from

  write(timing_file,'(a,i8.8,a1,i5.5)') trim(tchkpt_dir)//"/model_timing_",ymd,"_",tod

to

  write(timing_file,'(a,i8.8,a1,i5.5)') &
       trim(tchkpt_dir)//"/cesm_timing"//trim(cpl_inst_tag)//"_",ymd,"_",tod

It should instead be

  write(timing_file,'(a,i8.8,a1,i5.5)') &
       trim(tchkpt_dir)//"/model_timing"//trim(cpl_inst_tag)//"_",ymd,"_",tod

@rljacob and @jgfouca , I am willing to submit a PR with this fix, but will await your direction.
@rljacob
Copy link
Member

rljacob commented Apr 6, 2018

Sorry I missed that in ESMCI/cime#2387. Please make a PR. @jgfouca we should merge that before doing the next (last) E3SM -> ESCMI cime update.

@worleyph
Copy link
Contributor Author

worleyph commented Apr 6, 2018

How about issue #1981 . I can put both in the same PR.

@rljacob
Copy link
Member

rljacob commented Apr 6, 2018

Go ahead.

@worleyph worleyph mentioned this issue Apr 9, 2018
Merged
rljacob added a commit that referenced this issue Apr 10, 2018
@rljacob
Merge branch 'worleyph/cime/e3sm_no_recur' into next (PR #2266)
ee669b2 
The checkpoint timing files, in timing/checkpoints, are named

cesm_timing_<simulation_date_and_time>.

Replace the cesm_timing prefix with model_timing prefix.

Also eliminate the (unnecessary) recursive timer call to CPL:RUN
when do_budgets is .TRUE.

Fixes #2264
Fixes #1981

BFB
rljacob added a commit that referenced this issue Apr 13, 2018
@rljacob
Merge branch 'worleyph/cime/e3sm_no_recur' (PR #2266)
48c1121 
The checkpoint timing files, in timing/checkpoints, are named

cesm_timing_<simulation_date_and_time>.

Replace the cesm_timing prefix with model_timing prefix.

Also eliminate the (unnecessary) recursive timer call to CPL:RUN
when do_budgets is .TRUE.

Fixes #2264
Fixes #1981

[BFB]
jgfouca pushed a commit that referenced this issue Apr 27, 2018
@rljacob
Merge branch 'worleyph/cime/e3sm_no_recur' (PR #2266)
832e3f9 
The checkpoint timing files, in timing/checkpoints, are named

cesm_timing_<simulation_date_and_time>.

Replace the cesm_timing prefix with model_timing prefix.

Also eliminate the (unnecessary) recursive timer call to CPL:RUN
when do_budgets is .TRUE.

Fixes #2264
Fixes #1981

[BFB]
mt5555 pushed a commit that referenced this issue May 24, 2018
@jgfouca
Jgfouca/branch for acme split 2018 01 30 (#2264)
d3740b3 
Shared change list:
* bless_test_results fix using REALUSER
* more robust stderr presentation for run_cmd_no_fail

Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

Code review: @jedwards4b
rljacob pushed a commit that referenced this issue Apr 12, 2021
@jgfouca
Jgfouca/branch for acme split 2018 01 30 (#2264)
7637ed5 
Shared change list:
* bless_test_results fix using REALUSER
* more robust stderr presentation for run_cmd_no_fail

Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

Code review: @jedwards4b
rljacob added a commit that referenced this issue Apr 12, 2021
@rljacob
Merge branch 'worleyph/cime/e3sm_no_recur' (PR #2266)
66d330c 
The checkpoint timing files, in timing/checkpoints, are named

cesm_timing_<simulation_date_and_time>.

Replace the cesm_timing prefix with model_timing prefix.

Also eliminate the (unnecessary) recursive timer call to CPL:RUN
when do_budgets is .TRUE.

Fixes #2264
Fixes #1981

[BFB]
rljacob pushed a commit that referenced this issue Apr 21, 2021
@jgfouca
Jgfouca/branch for acme split 2018 01 30 (#2264)
cc1b92f 
Shared change list:
* bless_test_results fix using REALUSER
* more robust stderr presentation for run_cmd_no_fail

Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

Code review: @jedwards4b
rljacob added a commit that referenced this issue Apr 21, 2021
@rljacob
Merge branch 'worleyph/cime/e3sm_no_recur' (PR #2266)
22c28cf 
The checkpoint timing files, in timing/checkpoints, are named

cesm_timing_<simulation_date_and_time>.

Replace the cesm_timing prefix with model_timing prefix.

Also eliminate the (unnecessary) recursive timer call to CPL:RUN
when do_budgets is .TRUE.

Fixes #2264
Fixes #1981

[BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rljacob rljacob

Labels
bug CIME
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eliminate cesm prefix in filename and eliminate recursive timer call E3SM-Project/E3SM
3 participants
@rljacob @jgfouca @worleyph