Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./case.setup ignores changes to env_batch.xml #1210

Closed
worleyph opened this issue Jan 9, 2017 · 9 comments · Fixed by #1300
Closed

./case.setup ignores changes to env_batch.xml #1210

worleyph opened this issue Jan 9, 2017 · 9 comments · Fixed by #1300
Assignees

Comments

@worleyph
Copy link
Contributor

worleyph commented Jan 9, 2017

On Edison, if create a case (./create_newcase), execute ./case.setup, then change settings in env_batch.xml (like WALLTIME and QUEUE), then call ./case.setup again, the changes in env_batch.xml are not used to update case.run .

If I instead call ./case.setup -c followed by ./case.setup, then changes do take effect. However, this also sets BUILD_COMPLETE to .false. in env_build.xml.

According to @jgfouca , this is incorrect behavior, that ./case.setup should recognize and implement changes indicated in env_batch.xml.

@worleyph
Copy link
Contributor Author

Note that I edited the env_batch.xml manually - I did not use xmlchange. Perhaps this is the reason that the change was not recognized?

@jgfouca
Copy link
Member

jgfouca commented Jan 10, 2017

I'll test that.

@worleyph
Copy link
Contributor Author

Any progress? It is still happening in my recent Edison experiment.

@jgfouca
Copy link
Member

jgfouca commented Jan 23, 2017

@worleyph sorry this dropped off my radar. I will look at it today.

@jgfouca
Copy link
Member

jgfouca commented Jan 23, 2017

@worleyph , I tried this with both ESMCI and ACME and it doesn't matter if you run xmlchange or not, the case.run and case.test files will not get regenerated unless you clean the setup first.

I have a solution in mind that I'm going to propose to the ESMCI team.

@worleyph
Copy link
Contributor Author

@jgfouca , thanks.

@jgfouca
Copy link
Member

jgfouca commented Jan 24, 2017

This issue is fixed by
ESMCI/cime#1039

On the ESMCI side.

@jgfouca jgfouca closed this as completed Jan 24, 2017
@worleyph
Copy link
Contributor Author

Reopening until fix is in place and tested in ACME.

@worleyph worleyph reopened this Jan 31, 2017
@jgfouca
Copy link
Member

jgfouca commented Mar 15, 2017

This is now on master.

@jgfouca jgfouca closed this as completed Mar 15, 2017
agsalin pushed a commit that referenced this issue Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants