Skip to content

Commit

Permalink
Add a comment
Browse files Browse the repository at this point in the history
Test suite: None
Test baseline: N/A
Test namelist changes: N/A
Test status: N/A

Fixes: None

User interface changes?: No

Code review: None
  • Loading branch information
billsacks committed Aug 7, 2016
1 parent a4e379b commit a05e16e
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions utils/python/CIME/SystemTests/system_tests_compare_two_clone.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,18 @@ def _setup_cases(self):
self._common_setup()
self._case_one_setup()
# Flush the case so that, if errors occur later, then at least case 1 is
# in a correct, post-setup state. Note that case 1 will be in its
# post-setup state even if case 2 setup fails. Putting the case1 flush
# after case 2 setup doesn't seem to help with that (presumably some
# flush is called automatically), and anyway wouldn't help with things
# like appending to user_nl files (which don't rely on flush).
# in a correct, post-setup state. This is important because the mere
# existence of a case 2 directory signals that setup is done. So if the
# build fails and the user rebuilds, setup won't be redone - so it's
# important to ensure that the results of setup are flushed to disk.
#
# Note that case 1 will be in its post-setup state even if case 2 setup
# fails. Putting the case1 flush after case 2 setup doesn't seem to help
# with that (presumably some flush is called automatically), and anyway
# wouldn't help with things like appending to user_nl files (which don't
# rely on flush). So we just have to live with that possibility (but
# note that we print a warning to the log file if that happens, in the
# caller of this method).
self._case.flush()

# Set up case 2
Expand Down

0 comments on commit a05e16e

Please sign in to comment.