fix issues with code_checker and missed run_cmd changes

scripts/Tools/acme_check_env

@@ -37,23 +37,23 @@ formatter_class=argparse.ArgumentDefaultsHelpFormatter
 ###############################################################################
 def check_sh():
 ###############################################################################
-    stat = run_cmd('sh --version', ok_to_fail=True)[0]
+    stat = run_cmd('sh --version')[0]
     if stat != 0:
         LOG.append('* sh appears not to be available in your environment.')
         LOG.append('  Please make sure it exists in your PATH.')
 
 ###############################################################################
 def check_csh():  # Can't believe I'm actually checking for csh. -JNJ
 ###############################################################################
-    stat = run_cmd('csh --version', ok_to_fail=True)[0]
+    stat = run_cmd('csh --version')[0]
     if stat != 0:  # Also tolerates tcsh
         LOG.append('* csh appears not to be available in your environment.')
         LOG.append('  Please make sure it exists in your PATH.')
 
 ###############################################################################
 def check_perl_module(module_name):
 ###############################################################################
-    stat = run_cmd('perl -e "require %s;"' % module_name, ok_to_fail=True)[0]
+    stat = run_cmd('perl -e "require %s;"' % module_name)[0]
     if stat != 0:
         LOG.append('* ACME requires the Perl module %s, but it is not available.'%module_name)
         LOG.append('  Please make sure that it exists in your @INC.')
@@ -65,7 +65,7 @@ def check_perl():
     acme_perl_major_version = 5
     acme_perl_minor_version = 16
 
-    stat, output, _ = run_cmd("perl -e 'print $^V;'", ok_to_fail=True)
+    stat, output, _ = run_cmd("perl -e 'print $^V;'")
     if stat != 0:
         LOG.append('* Perl appears not to be available in your environment.')
         LOG.append('  Please make sure it exists in your PATH.')
@@ -90,7 +90,7 @@ def check_git():
     acme_git_major_version = 2
     acme_git_minor_version = 0
 
-    stat, output, _ = run_cmd('git --version', ok_to_fail=True)
+    stat, output, _ = run_cmd('git --version')
     if stat != 0:
         LOG.append('* Git appears not to be available in your environment.')
         LOG.append('  Please make sure it exists in your PATH.')
@@ -116,7 +116,7 @@ def check_svn():
     acme_svn_minor_version = 4
     acme_svn_patch_version = 2
 
-    stat, output, _ = run_cmd('svn --version --quiet', ok_to_fail=True)
+    stat, output, _ = run_cmd('svn --version --quiet')
     if stat != 0:
         LOG.append('* Subversion appears not to be available in your environment.')
         LOG.append('  Please make sure it exists in your PATH.')

scripts/Tools/case_diff

@@ -103,14 +103,14 @@ def recursive_diff(dir1, dir2, show_binary=False, skip_list=[]):
             # if (os.path.getsize(path1) != os.path.getsize(path2)):
             #     print path1 + " DIFFERS (contents)"
 
-            stat, out, err = run_cmd("file %s" % path1, ok_to_fail=True)
+            stat, out, err = run_cmd("file %s" % path1)
             if (stat != 0):
                 logging.warn("Failed to probe file '%s', out: '%s', err: '%s'" % (path1, out, err))
                 continue
 
             is_text_file = "text" in out
             if (not (not show_binary and not is_text_file)):
-                stat, out, _ = run_cmd("diff -w %s %s" % (path1, path2), ok_to_fail=True)
+                stat, out, _ = run_cmd("diff -w %s %s" % (path1, path2))
                 if (stat != 0):
                     print "==============================================================================="
                     print path1 + " DIFFERS (contents)"

scripts/Tools/code_checker

@@ -54,9 +54,9 @@ def run_pylint(on_file):
     expect(pylint is not None,"pylint not found")
 
     cmd = "%s --disable I,C,R,logging-not-lazy,wildcard-import,unused-wildcard-import,fixme,broad-except,bare-except,eval-used,exec-used,global-statement %s" % (pylint, on_file)
-    stat = run_cmd(cmd)[0]
+    stat, out, err = run_cmd(cmd)
     if stat != 0:
-        sys.stdout.write("File %s has pylint problems, please fix\n    Use command: %s\n" % (on_file, cmd))
+        sys.stdout.write("File %s has pylint problems, please fix\n    Use command: %s\n%s\n %s\n %s\n" % (on_file, cmd, stat, out, err))
         return False
     else:
         sys.stdout.write("File %s has no pylint problems\n" % on_file)
@@ -72,7 +72,7 @@ def check_code(dir_to_check, num_procs):
     """
     # Pylint won't work right if the imports within the checked files fails
     if "PYTHONPATH" in os.environ:
-        os.environ["PYTHONPATH"] += dir_to_check
+        os.environ["PYTHONPATH"] += ':' + dir_to_check
     else:
         os.environ["PYTHONPATH"] = dir_to_check