Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear selection on double-click #691

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Clear selection on double-click #691

merged 2 commits into from
Apr 30, 2021

Conversation

e9gille
Copy link
Contributor

@e9gille e9gille commented Apr 30, 2021

There's no way to prevent the default behaviour of monaco to select a word when double-clicking, so undo this by setting the cursor explicitly.

@e9gille e9gille requested review from mbaas2 and JonnersW April 30, 2021 05:29
@e9gille e9gille linked an issue Apr 30, 2021 that may be closed by this pull request
When dbl-clicking a fn in session to edit, it should not be selected #668
Closed
@abrudz
Copy link
Member

abrudz commented Apr 30, 2021

Maybe this should be an option like in the IDE?
image

JonnersW
JonnersW approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@JonnersW JonnersW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@e9gille e9gille merged commit b4a9c78 into master Apr 30, 2021
@e9gille e9gille deleted the iss668 branch April 30, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonnersW JonnersW JonnersW approved these changes

@mbaas2 mbaas2 Awaiting requested review from mbaas2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When dbl-clicking a fn in session to edit, it should not be selected
3 participants
@e9gille @abrudz @JonnersW