Use Subscribe feature for status updates #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, tested with 18.0 and 18.1 and the fallback seems to work as expected. |
This was
linked to
issues
Apr 29, 2021
…n while I grapple with the CSS/Less
e9gille
commented
Apr 29, 2021
index.html
Outdated
| <div id=sb_trap class=right title="Trap Event" hidden>⎕TRAP</div> | ||
| <div id=sb_dq class=right title="Dequeue Events" hidden>⎕DQ: </div> | ||
| <div id=sb_threads class=right title="Thread Count" hidden>&: </div> | ||
| <div id=sb_cc class=right title="Compact Cleaner" hidden>CC: </div> |
There was a problem hiding this comment.
Maybe should say Count of compactions performed
src/ide.js
Outdated
Comment on lines
757
to
758
| I.sb_cc.classList.toggle('active', x.CompactCount !== 1); | ||
| I.sb_gc.classList.toggle('active', x.GarbageCount !== 0); |
There was a problem hiding this comment.
These 2 will only ever increase, so either don't make them active or (if we want to indicate when an increase happens) activate them on increase and then let them fade back after some time.
JonnersW
approved these changes
Apr 30, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.