Separate OSX building and Notarization in CI Builds #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9gille
approved these changes
Aug 30, 2023
|
Forget what I said, those should have been provided already. |
|
It was failing because we took the decision to only notarize on 1 mac - I had completely forgotten that conversation with Andy, so I moved things around to stash the files after building/signing and then notarize on the other mac, This also means there's some common code between the OSXpackaging and the notarize script, so we should perhaps create a common script for that information (mostly building up what the package name is). But that will be a later project. |
|
OK, that explains it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out the Notarization for OSX builds to use a different system with the notary tool, Internally this means that all notarizations are done from a single host.
This is in update to #1094 and #999