Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adress os-locale 6.0.0 breaking change #1112

Closed
TomaSajt opened this issue Aug 27, 2023 · 1 comment
Closed

Adress os-locale 6.0.0 breaking change #1112

TomaSajt opened this issue Aug 27, 2023 · 1 comment

Comments

@TomaSajt
Copy link

Describe the issue you are having

The os-locale dependency has been updated in a recent commit from 5.0.0 to 6.0.2.

However there was a breaking change between major versions, which was that os-locale became a pure ESM package.

Changelog of os-locale 6.0.0
The package owner's proposed solutions for using the package with Electron

I did not notice this change, because of my saved preferences (in prefs.js the kbdLocale field), however, once I deleted my RIDE config directory, (or just the prefs file,) it couldn't start the interpreter, because of errors being thrown about not being able to require(...) ESM modules.

I think it is acceptable to revert the version of os-locale to 5.0.0

@e9gille
Copy link
Contributor

e9gille commented Aug 27, 2023

well spotted, will downgrade as suggested

e9gille added a commit that referenced this issue Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants