fix(get-results): empty results on clicking "Get Results" #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Monik2002 PR title is too long, give a reasonable summary not more than 10 words. Fix the build error, try |
Dun-sin
requested changes
Oct 21, 2023
There was a problem hiding this comment.
Remove everything here, not part of your issue
There was a problem hiding this comment.
Remove everything here, not part of your issue
There was a problem hiding this comment.
Remove everything that has to do with the error message, look at how prevention of open get results page and just implement it the same.
There was a problem hiding this comment.
okay thanks i will work on that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue --> Empty results
My PR closes #504
👨💻 Changes proposed(What did you do ?)
now the whole problem is when we "Add New Color" and leave it empty i.e. leave any of the "Tap to pick a color" empty (with some text already in the "Enter the text" area) when we click on "get results" we get nothing (empty) . what we need to do/fix - we need to restrict the user from clicking "get results" until all the "Tap to pick a color" is filled.
📷 Screenshots