Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unnecessary active background #261

Merged
merged 1 commit into from
Oct 10, 2022
Merged

fix: Remove unnecessary active background #261

merged 1 commit into from
Oct 10, 2022

Conversation

eddybruv
Copy link
Contributor

@eddybruv eddybruv commented Oct 9, 2022 •
edited
Loading

🛠️ Fixes Issue

Closes #255

👨‍💻 Changes proposed

  • Added an event listener that clears the generator nav styling when "Code Magic" is clicked

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@vercel
Copy link

vercel bot commented Oct 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
code-magic ✅ Ready (Inspect) Visit Preview Oct 9, 2022 at 5:40PM (UTC)

github-actions[bot]
github-actions bot reviewed Oct 9, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Dun-sin
Dun-sin reviewed Oct 9, 2022
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a Pull Request and contributing to our community project 🎉. Someone from the community will get back to you soon, usually within 24 hours

@eddybruv eddybruv changed the title added event listener to solve issue #255 [Bug Fix] Remove unnecessary active background Oct 9, 2022
@eddybruv eddybruv changed the title [Bug Fix] Remove unnecessary active background [Fixes #255] Remove unnecessary active background Oct 9, 2022
@eddybruv eddybruv changed the title [Fixes #255] Remove unnecessary active background fix: Remove unnecessary active background Oct 9, 2022
@eddybruv
Copy link
Contributor Author

eddybruv commented Oct 9, 2022

@Dun-sin sorry for all the edits, I seem to be messing up the PR style and specs.

Dun-sin
Dun-sin approved these changes Oct 10, 2022
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👌🏾 Thank you for contributing, your PR is accepted, I hope you continue to contribute to this project

Check out the community discord server 👉🏽here👈🏽

@Dun-sin Dun-sin merged commit 63f4100 into Dun-sin:main Oct 10, 2022
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 10, 2022

🎉 This PR is included in version 2.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@eddybruv eddybruv deleted the bug-255 branch October 10, 2022 08:16
@eddybruv
Copy link
Contributor Author

Thanks @Dun-sin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Dun-sin Dun-sin Dun-sin approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] unnecessary active background
2 participants
@eddybruv @Dun-sin