Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Custom Border Radius Generator #215

Merged
merged 3 commits into from
Oct 10, 2022
Merged

feat: Custom Border Radius Generator #215

merged 3 commits into from
Oct 10, 2022

Conversation

ManishBisht777
Copy link
Contributor

@ManishBisht777 ManishBisht777 commented Oct 2, 2022 •
edited
Loading

🛠️ Fixes Issue #99

fix #99

👨‍💻 Changes proposed

  • Created a Custom Border radius Generator

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Screenshot (52)
Screenshot (53)

@vercel
Copy link

vercel bot commented Oct 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
code-magic ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 11:16AM (UTC)

Dun-sin
Dun-sin reviewed Oct 2, 2022
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a Pull Request and contributing to our community project 🎉. Someone from the community will get back to you soon, usually within 24 hours

github-actions[bot]
github-actions bot reviewed Oct 2, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 4, 2022 •
edited
Loading

2 things to work on here:

  • Give the users option to apply a color at least
  • Take away the border radius code

@ManishBisht777 ManishBisht777 requested a review from Dun-sin October 5, 2022 08:40
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 7, 2022

@ManishBisht777 an update here is needed

@ManishBisht777
Copy link
Contributor Author

@Dun-sin whats the need of color in border radius and you can copy the generated code for the radius

I check the preview and its working fine

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 10, 2022

@Dun-sin whats the need of color in border radius and you can copy the generated code for the radius

I check the preview and its working fine

You are right about the color, that's what the next screen is for. Copying the style. Hence me asking you to remove it from the main screen

@ManishBisht777
Copy link
Contributor Author

@Dun-sin sorry i forgot to check the comment here

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 10, 2022

If you don't want to work on it anymore, let me know

@ManishBisht777
Copy link
Contributor Author

sure i will make the chnages needed

@ManishBisht777
Copy link
Contributor Author

oh you mean this sure will remove this form here
image

@ManishBisht777
Copy link
Contributor Author

@Dun-sin will make the changes

@ManishBisht777
Copy link
Contributor Author

@Dun-sin committed the changes you can check

Dun-sin
Dun-sin previously approved these changes Oct 10, 2022
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👌🏾 Thank you for contributing, your PR is accepted, I hope you continue to contribute to this project

@ManishBisht777
Copy link
Contributor Author

Sure, will contribute more, I am waiting for this pr to get accepted before moving to another pr, and I didn't notice the message you dropped here sorry for the delay again

@Dun-sin Dun-sin merged commit 46f8925 into Dun-sin:main Oct 10, 2022
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 10, 2022

🎉 This PR is included in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Dun-sin Dun-sin Dun-sin approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make a custom border radius generator.
2 participants
@ManishBisht777 @Dun-sin