Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] change caret and placeholder colour #534

Closed
Dun-sin opened this issue Oct 24, 2023 · 14 comments · Fixed by #541
Closed

[FEATURE] change caret and placeholder colour #534

Dun-sin opened this issue Oct 24, 2023 · 14 comments · Fixed by #541
Assignees
Labels
assigned Issue is no longer available for anyone else to work on feature hacktoberfest released

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 24, 2023

Description

This issue just applies to the input range radius

  • caret and placeholder colors should be -> var(--text-color)

Screenshots

image

Are you willing to work on this issue ?

None

@Dun-sin Dun-sin added feature up for grabs Issue is still available for anyone to work on hacktoberfest labels Oct 24, 2023
@github-actions
Copy link

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓

@abhinavs1920
Copy link

Can I work on this issue?

@avibiradar100
Copy link
Contributor

Hey @Dun-sin could you please assign me to this issue

@Dun-sin
Copy link
Owner Author

Dun-sin commented Oct 24, 2023

Can I work on this issue?

Sure, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

@Dun-sin Dun-sin added assigned Issue is no longer available for anyone else to work on and removed up for grabs Issue is still available for anyone to work on labels Oct 24, 2023
@Dun-sin
Copy link
Owner Author

Dun-sin commented Oct 31, 2023

@avibiradar100 please raise a PR today, else you will be unassigned

@Raj100679
Copy link
Contributor

Hello @Dun-sin , Can you assign this issue to me?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Nov 3, 2023

Hello @Dun-sin , Can you assign this issue to me?

Sure, thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions on the discord server. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

@Dun-sin Dun-sin assigned Raj100679 and unassigned abhinavs1920 Nov 3, 2023
@Raj100679
Copy link
Contributor

@Dun-sin
Screenshot (108)
I am not able to see caret

@Dun-sin
Copy link
Owner Author

Dun-sin commented Nov 4, 2023

@Dun-sin Screenshot (108) I am not able to see caret

yeah, that's what the issue fixes, change the color and you will

@Raj100679
Copy link
Contributor

I am sorry, I am not able to understand what I have to do

@Dun-sin
Copy link
Owner Author

Dun-sin commented Nov 4, 2023

I am sorry, I am not able to understand what I have to do

Do you know what a caret is and how to change it? I think the issue description is very explanatory, it boils down to what you understand about a caret and placeholder, did you know you can change their colors and do you know what a variable in CSS is?

@Raj100679
Copy link
Contributor

My question is why cant i view that input box fully ? I know variables in css and I know how to change colors of caret and place holder

@Dun-sin
Copy link
Owner Author

Dun-sin commented Nov 4, 2023

My question is why cant i view that input box fully ? I know variables in css and I know how to change colors of caret and place holder

Because it's designed that way, technically it's just a number so the input box doesn't need to be big like the rest at the top.

Did you try changing the colors first and seeing if that did anything? Because as I said that's the point of the issue.

Dun-sin pushed a commit that referenced this issue Nov 5, 2023
Co-authored-by: Raj <rajkasat@yo.com>
@Dun-sin
Copy link
Owner Author

Dun-sin commented Nov 5, 2023

🎉 This issue has been resolved in version 2.75.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Issue is no longer available for anyone else to work on feature hacktoberfest released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants