Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid generator #434

Closed
2 tasks done
Thilakmani-dev opened this issue Aug 2, 2023 · 22 comments · Fixed by #483
Closed
2 tasks done

Grid generator #434

Thilakmani-dev opened this issue Aug 2, 2023 · 22 comments · Fixed by #483
Assignees
Labels
assigned Issue is no longer available for anyone else to work on feature released

Comments

@Thilakmani-dev
Copy link
Contributor

Description

I am proposing this idea to add a grid generator into code magic, have tried some research, and did some wireframes, and it will be useful for other developers if we add this grid generator, so the generated CSS can be easily used. #5

Screenshots

grid-generator

Additional information

No response

👀 Have you checked if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓

@Dun-sin Dun-sin added the assigned Issue is no longer available for anyone else to work on label Aug 2, 2023
@Dun-sin
Copy link
Owner

Dun-sin commented Aug 2, 2023

Assigned to you, please read the rules in the contributing file

@Thilakmani-dev
Copy link
Contributor Author

Thank you @Dun-sin , i have read the contributing file

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 12, 2023

hi, @Thilakmani-dev an update please?

@Dun-sin Dun-sin added up for grabs Issue is still available for anyone to work on and removed assigned Issue is no longer available for anyone else to work on labels Aug 19, 2023
@Thilakmani-dev
Copy link
Contributor Author

Yes @Dun-sin , i have gone through the code, started my work on this

@Thilakmani-dev
Copy link
Contributor Author

Please assign this issue to me, i didn't see the previous comments

@Dun-sin Dun-sin added assigned Issue is no longer available for anyone else to work on and removed up for grabs Issue is still available for anyone to work on labels Aug 26, 2023
@Dun-sin
Copy link
Owner

Dun-sin commented Aug 26, 2023

Please assign this issue to me, i didn't see the previous comments

Okay, when can I expect a pull request? Just to doesn't have to be fixed, just want to check in again at that time.

@Thilakmani-dev
Copy link
Contributor Author

i will show you the progress in next week, is that fine @Dun-sin

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 26, 2023

i will show you the progress in next week, is that fine @Dun-sin

That's alright, good luck🍀💪🏽

@Thilakmani-dev
Copy link
Contributor Author

Hi @Dun-sin i was sick last week, did some progress to start today
Screenshot 2023-09-03 at 10 45 32 PM
I am learning your code too, will post updates here

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 19, 2023

Hi @Thilakmani-dev an update please?

@Thilakmani-dev
Copy link
Contributor Author

yes @Dun-sin , I will share the completed part by this week

@Thilakmani-dev
Copy link
Contributor Author

Screenshot 2023-09-25 at 10 22 54 AM there's some css and bug fixes there, working on that @Dun-sin, hopefully will complete whole thing by this week

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 25, 2023

Screenshot 2023-09-25 at 10 22 54 AM there's some css and bug fixes there, working on that @Dun-sin, hopefully will complete whole thing by this week

Perfect👍🏽 thanks for the update

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 25, 2023

Screenshot 2023-09-25 at 10 22 54 AM there's some css and bug fixes there, working on that @Dun-sin, hopefully will complete whole thing by this week

Perfect👍🏽 thanks for the update

Looks like the grid generator is under the wrong category, shouldn't be input, but display

@Thilakmani-dev
Copy link
Contributor Author

Screenshot 2023-09-25 at 10 22 54 AM there's some css and bug fixes there, working on that @Dun-sin, hopefully will complete whole thing by this week

Perfect👍🏽 thanks for the update

Looks like the grid generator is under the wrong category, shouldn't be input, but display

will look into this @Dun-sin

@Thilakmani-dev
Copy link
Contributor Author

Hi @Dun-sin , i have completed the part, here is the preview of the output
Screenshot 2023-10-01 at 12 25 19 AM
Can I raise the #pr

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 30, 2023

Hi @Dun-sin , i have completed the part, here is the preview of the output Screenshot 2023-10-01 at 12 25 19 AM Can I raise the #pr

sure, follow the guidelines for making a PR in this project

@Thilakmani-dev
Copy link
Contributor Author

#475

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 1, 2023

#475

keep in mind in the future you don't need to comment back on the Issue, it's not my first rodeo, so I see your PR and will definitely do the necessary. It will just cause unnecessary notifications for me and others.

@Thilakmani-dev
Copy link
Contributor Author

okay @Dun-sin , will keep in mind

Thilakmani-dev pushed a commit to Thilakmani-dev/Code-Magic that referenced this issue Oct 2, 2023
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 2, 2023

🎉 This issue has been resolved in version 2.68.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Issue is no longer available for anyone else to work on feature released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants