Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect count of LOCF in generateMissingWeather() #437

Closed
dschlaep opened this issue Nov 25, 2024 · 0 comments · Fixed by #436
Closed

Incorrect count of LOCF in generateMissingWeather() #437

dschlaep opened this issue Nov 25, 2024 · 0 comments · Fixed by #436
Assignees
@dschlaep
Labels
bug
Milestone
Release v8+

Comments

@dschlaep
Copy link
Member

generateMissingWeather() is supposed to count the number of days on which a missing value was replaced by a non-missing value from the preceding day for the method "LOCF" (last observation carried forward).

Currently, however, any day with any missing value is included towards that total count -- even if the only missing values are from a variable not provided via daily inputs, e.g., solar radiation, or vapor pressure.
@dschlaep dschlaep self-assigned this Nov 25, 2024
@dschlaep dschlaep added the bug label Nov 25, 2024
@dschlaep dschlaep added this to the Release v8+ milestone Nov 25, 2024
@dschlaep dschlaep linked a pull request Nov 25, 2024 that will close this issue
Bugfix435: calculated relative humidity #436
Merged
@dschlaep dschlaep mentioned this issue Nov 25, 2024
Merged
dschlaep added a commit that referenced this issue Nov 26, 2024
@dschlaep
Merge pull request #436 from DrylandEcology/bugfix435ForV800_calculat…
ccce564 
…edRelativeHumidity

Bugfix435: calculated relative humidity; count of missing weather LOCF

* Fix the calculation of relative humidity (close #435). Previously, relative humidity was incorrectly calculated if based on vapor pressure or specific humidity.

* Fix the count of days on which a missing weather value was replaced by a non-missing value from the preceding day for the method `"LOCF"` (last observation carried forward; close #437). Previously, any day with a missing weather value was counted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dschlaep dschlaep

Labels
bug
Projects
None yet
Milestone
Release v8+
Development

Successfully merging a pull request may close this issue.

Bugfix435: calculated relative humidity DrylandEcology/SOILWAT2
1 participant
@dschlaep