Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation with pip in edit mode #26

Merged
merged 11 commits into from
Oct 11, 2024

Conversation

ROBERT-MCDOWELL
Copy link
Collaborator

@ROBERT-MCDOWELL ROBERT-MCDOWELL commented Oct 11, 2024

Added files to let the user/developer to install in edit mode (pip install -e .)

  • setup.py
  • requirements.txt
  • pyproject.toml

IMPORTANT: if the app.py is still the script to run it should contain a "main" function, otherwise it will be not possible to
call directly ebook2audiobookXTTS as an app name.

Worth to advise the user/develpoer to install a virtual python env v3.10 min, v3.11 max, with for i.e. conda
(I tried with python 3.11 and everything is ok)
conda create --prefix /path/to/env-folder python=3.11
conda activate /path/to/env-folder
...
conda deactivate

@DrewThomasson DrewThomasson merged commit 4012431 into DrewThomasson:main Oct 11, 2024
@DrewThomasson
Copy link
Owner

WOH! 😲🤩

Dang! you did way more than I would of done!
This is Awesome!

@ROBERT-MCDOWELL
Copy link
Collaborator Author

wait. I have to fix some important things yet. next PR ok?

@DrewThomasson
Copy link
Owner

DrewThomasson commented Oct 11, 2024

Oops, ill revert it

Was about to ask about what you meant about having a main

@DrewThomasson
Copy link
Owner

Reverted

@ROBERT-MCDOWELL
Copy link
Collaborator Author

ok I do the fix and run a PR again

@DrewThomasson
Copy link
Owner

I await your updated merge 👍

@DrewThomasson
Copy link
Owner

DrewThomasson commented Oct 11, 2024

Byeah hit me up when it's ready

I'm still new to this lol

  • +I'll probs end up responding tomorrow

@ROBERT-MCDOWELL
Copy link
Collaborator Author

ok no worries, I'm done for today, tomorrow all will be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants