-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation with pip in edit mode #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add setup.py to allow pip installation
WOH! 😲🤩Dang! you did way more than I would of done! |
wait. I have to fix some important things yet. next PR ok? |
Oops, ill revert it Was about to ask about what you meant about |
Reverted |
ok I do the fix and run a PR again |
I await your updated merge 👍 |
Byeah hit me up when it's ready I'm still new to this lol
|
ok no worries, I'm done for today, tomorrow all will be good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added files to let the user/developer to install in edit mode (pip install -e .)
IMPORTANT: if the app.py is still the script to run it should contain a "main" function, otherwise it will be not possible to
call directly ebook2audiobookXTTS as an app name.
Worth to advise the user/develpoer to install a virtual python env v3.10 min, v3.11 max, with for i.e. conda
(I tried with python 3.11 and everything is ok)
conda create --prefix /path/to/env-folder python=3.11
conda activate /path/to/env-folder
...
conda deactivate