preact/signals: move enum-dependent code to .ts file #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves some type definitions in
3rdparty/preact/signals/internal.d.ts
into the corresponding.ts
file. Specifically, it moves anenum
declaration from.d.ts
to.ts
, and also moves any dependent types.The reason is that
enum
is subtly broken in.d.ts
files, even if it isconst enum
. This doesn't cause issues fortsc
, but it does cause problems if you're bundling ScriptLib using the source.ts
files via a bundler such as esbuild.To my mind,
const enum
ought to be fine in a.d.ts
file, but the maintainer of esbuild seems to disagree.It is possible that downstream code is including the types extracted from
internal.d.ts
, but I think the risk is low. Those types don't seem to be very useful outside ofsignals/index.ts
, so it shouldn't break anything unless the downstream code was doing something really weird.