Feature/logging/verbose #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
reviewed
Nov 6, 2019
added 2 commits
November 7, 2019 11:32
1fa1c55 to
14bfdfa
Compare
lacostej
approved these changes
Nov 7, 2019
| { | ||
| previouslyFilteredType = Debug.logger.filterLogType; | ||
| Debug.logger.filterLogType = logType; |
There was a problem hiding this comment.
OK so you are changing all loggers during the time uplift is doing its work.
This also assumes nothing is happening in the background (e.g. threads).
Fine for now, but probably we should just rewrite this log handler by creating a special Logger instance with our file writer in it. It might be more logical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Preference to enable or disable verbose mode, to reduce the size of the log files