Preferences: use .uplift/preferences.xml rather than EditorPrefs for storage #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc9baf8 to
b39e233
Compare
lacostej
reviewed
Dec 18, 2018
d317a0a to
eec2d98
Compare
lacostej
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several issues have been noticed with the uplift preferences being in the EditorPrefs:
For these reasons, this moves Uplift preferences to a storage we have much more control over, .uplift/preferences.xml.
NOTE: It would have been better to put these preferences into the settings file as proposed in #62 , but it cannot be modified or it breaks backward compatibility.