Allow inheritdoc for class constructors with base types #3719
+184
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3719 +/- ##
========================================
Coverage 97.40% 97.40%
========================================
Files 914 915 +1
Lines 108762 108975 +213
Branches 3284 3292 +8
========================================
+ Hits 105937 106147 +210
- Misses 1847 1849 +2
- Partials 978 979 +1 |
|
@bjornhellander I noticed your #3715. Perhaps if you have a minute, could you take a look at this PR please? |
|
Thinking about the implementation a bit more, it is likely wrong. It is more like a heuristic. I need to investigate a bit more in my MSVS when the inheritdoc attribute works for ctors. Any guidance would be certainly helpful. |
|
My understanding is that the signature has to match a constructor from a base class for the |
|
Yeah, based on my playing with code, it seems to be the case. Is there possibly some useful method for getting "constructor with the same signature"? Or does one have to implement it from scratch? edit: Maybe this https://stackoverflow.com/questions/66113790/how-to-check-if-two-methods-match-signature-via-roslyn will be helpful. |
|
I am not aware of any nice utility methods for this. |
|
@sharwell Any feedback please how you would approach it? |
...yzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs
Outdated
Show resolved
Hide resolved
| { | ||
| INamedTypeSymbol baseType = enclosingNamedTypeSymbol.BaseType; | ||
|
|
||
| if (baseType.SpecialType != SpecialType.System_Object) |
There was a problem hiding this comment.
Do we really want it to trigger for this case? Maybe not the best documentation, but the use of inheritdoc seems to be correct:
What do you think, @sharwell?
There was a problem hiding this comment.
I have added support for this case to follow the VS approach.
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Outdated
Show resolved
Hide resolved
...yzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs
Outdated
Show resolved
Hide resolved
|
Apart from my question about inheriting from Object, I think the analyzer changes look correct. I would just like to see more tests and improved readability. 👍 |
MartyIX
commented
Nov 11, 2023
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Show resolved
Hide resolved
MartyIX
commented
Nov 11, 2023
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Show resolved
Hide resolved
This reverts commit 50a5fbf.
...yzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Show resolved
Hide resolved
...yzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs
Outdated
Show resolved
Hide resolved
|
When you are done with everything mentioned so far, ping sharwell. 👍 |
# Conflicts: # azure-pipelines.yml
|
@sharwell Could I ask for some feedback please? |
sharwell
reviewed
Dec 19, 2023
| namespace StyleCop.Analyzers.Test.DocumentationRules | ||
| { | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.CodeAnalysis.Testing; | ||
| using Microsoft.VisualBasic.Devices; |
There was a problem hiding this comment.
That's on Visual Studio. Not me. Obviously. ;) Removed.
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs
Show resolved
Hide resolved
...yzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs
Outdated
Show resolved
Hide resolved
...yzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Dec 19, 2023
renovate bot
referenced
this pull request
in smartive/cas-fee-adv-mumble-api
Dec 21, 2023
…20) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [StyleCop.Analyzers](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers) | `1.2.0-beta.507` -> `1.2.0-beta.556` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DotNetAnalyzers/StyleCopAnalyzers (StyleCop.Analyzers)</summary> ### [`v1.2.0-beta.556`](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.556) [Compare Source](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.553...1.2.0-beta.556) #### What's Changed - Update SA1011 to forbid trailing space before the end of a switch case by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3674](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3674) - Rewrite IOperationWrapper as a wrapper structure around IOperation by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3611](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3611) - Update SA1202 to support interfaces (C# 8) and records (C# 9, 10) by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3694](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3694) - Update documentation for SA1308 to also mention prefix "t\_" by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3697](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3697) - Update SA1642 and its code fix to handle record structs correctly by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3696](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3696) - Update dependencies by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3700](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3700) - Mark several test classes as partial by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3702](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3702) - Add missing test files and fix inheritance by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3703](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3703) - Generate and validate derived test classes by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3704](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3704) - Update SA1011 to not require space before a range operator by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3709](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3709) - Update SA1131 to treat methods as constants by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3710](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3710) - Avoid allocations in CanWrap... methods by [@​martin-strecker-sonarsource](https://togithub.com/martin-strecker-sonarsource) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711) - Update SA1648 to accept inheritdoc on members implemented from static abstract/virtual interface members by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3715](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3715) - Update SA1600 to also handle records by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3725](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3725) - Update SA1119 to allow parenthesis around a ref ternary conditional expression when it is the left-hand side of an assigment by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3737](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3737) - Update SA1119 to allow parenthesized switch expressions followed by an invocation by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3733](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3733) - Add c# 12 test project by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3734](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3734) - Run tests in parallel jobs by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3740](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3740) - Update SA1010 to accept whitespace before collection initializers by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3745](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3745) - Update SA1513 to not require a blank line if the closing brace is at the end of a collection expression by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3746](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3746) - Update SA1118 to allow multi-line collection expressions by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3749](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3749) - Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3750](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3750) - Update SA1008 to allow space before the opening parenthesis of a using alias definition of a tuple type by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3748](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3748) - Update documentation for SA1102 to contain compilable code examples by [@​arphox](https://togithub.com/arphox) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755) - Update SA1008 to not crash if there is no previous token by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3741](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3741) - Change default value of test property CodeActionValidationMode to SemanticStructure instead of None and update so that tests still pass by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3753](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3753) - Allow inheritdoc for class constructors with base types by [@​MartyIX](https://togithub.com/MartyIX) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719) - Fix that SA1134 Fix All maybe non-deterministic by [@​pdelvo](https://togithub.com/pdelvo) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/2853](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/2853) - Coverage improvements by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3675](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3675) - Fix SA1131 to not treat "complex" expressions as a literal by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3760](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3760) #### New Contributors - [@​martin-strecker-sonarsource](https://togithub.com/martin-strecker-sonarsource) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711) - [@​arphox](https://togithub.com/arphox) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755) - [@​MartyIX](https://togithub.com/MartyIX) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719) **Full Changelog**: DotNetAnalyzers/StyleCopAnalyzers@1.2.0-beta.507...1.2.0-beta.556 ### [`v1.2.0-beta.553`](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.553) [Compare Source](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.507...1.2.0-beta.553) ##### What's Changed - Update SA1011 to forbid trailing space before the end of a switch case by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3674](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3674) - Rewrite IOperationWrapper as a wrapper structure around IOperation by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3611](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3611) - Update SA1202 to support interfaces (C# 8) and records (C# 9, 10) by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3694](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3694) - Update documentation for SA1308 to also mention prefix "t\_" by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3697](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3697) - Update SA1642 and its code fix to handle record structs correctly by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3696](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3696) - Update dependencies by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3700](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3700) - Mark several test classes as partial by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3702](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3702) - Add missing test files and fix inheritance by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3703](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3703) - Generate and validate derived test classes by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3704](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3704) - Update SA1011 to not require space before a range operator by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3709](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3709) - Update SA1131 to treat methods as constants by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3710](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3710) - Avoid allocations in CanWrap... methods by [@​martin-strecker-sonarsource](https://togithub.com/martin-strecker-sonarsource) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711) - Update SA1648 to accept inheritdoc on members implemented from static abstract/virtual interface members by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3715](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3715) - Update SA1600 to also handle records by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3725](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3725) - Update SA1119 to allow parenthesis around a ref ternary conditional expression when it is the left-hand side of an assigment by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3737](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3737) - Update SA1119 to allow parenthesized switch expressions followed by an invocation by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3733](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3733) - Add c# 12 test project by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3734](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3734) - Run tests in parallel jobs by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3740](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3740) - Update SA1010 to accept whitespace before collection initializers by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3745](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3745) - Update SA1513 to not require a blank line if the closing brace is at the end of a collection expression by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3746](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3746) - Update SA1118 to allow multi-line collection expressions by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3749](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3749) - Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3750](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3750) - Update SA1008 to allow space before the opening parenthesis of a using alias definition of a tuple type by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3748](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3748) - Update documentation for SA1102 to contain compilable code examples by [@​arphox](https://togithub.com/arphox) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755) - Update SA1008 to not crash if there is no previous token by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3741](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3741) - Change default value of test property CodeActionValidationMode to SemanticStructure instead of None and update so that tests still pass by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3753](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3753) - Allow inheritdoc for class constructors with base types by [@​MartyIX](https://togithub.com/MartyIX) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719) - Fix that SA1134 Fix All maybe non-deterministic by [@​pdelvo](https://togithub.com/pdelvo) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/2853](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/2853) - Coverage improvements by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3675](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3675) ##### New Contributors - [@​martin-strecker-sonarsource](https://togithub.com/martin-strecker-sonarsource) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711) - [@​arphox](https://togithub.com/arphox) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755) - [@​MartyIX](https://togithub.com/MartyIX) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719) **Full Changelog**: DotNetAnalyzers/StyleCopAnalyzers@1.2.0-beta.507...1.2.0-beta.553 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/smartive/cas-fee-adv-mumble-api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
ThorstenSauter
referenced
this pull request
in ThorstenSauter/NoPlan
Dec 21, 2023
…591) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [StyleCop.Analyzers](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers) | `1.2.0-beta.507` -> `1.2.0-beta.556` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DotNetAnalyzers/StyleCopAnalyzers (StyleCop.Analyzers)</summary> ### [`v1.2.0-beta.556`](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.556) [Compare Source](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.553...1.2.0-beta.556) #### What's Changed - Update SA1011 to forbid trailing space before the end of a switch case by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3674](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3674) - Rewrite IOperationWrapper as a wrapper structure around IOperation by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3611](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3611) - Update SA1202 to support interfaces (C# 8) and records (C# 9, 10) by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3694](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3694) - Update documentation for SA1308 to also mention prefix "t\_" by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3697](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3697) - Update SA1642 and its code fix to handle record structs correctly by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3696](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3696) - Update dependencies by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3700](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3700) - Mark several test classes as partial by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3702](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3702) - Add missing test files and fix inheritance by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3703](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3703) - Generate and validate derived test classes by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3704](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3704) - Update SA1011 to not require space before a range operator by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3709](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3709) - Update SA1131 to treat methods as constants by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3710](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3710) - Avoid allocations in CanWrap... methods by [@​martin-strecker-sonarsource](https://togithub.com/martin-strecker-sonarsource) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711) - Update SA1648 to accept inheritdoc on members implemented from static abstract/virtual interface members by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3715](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3715) - Update SA1600 to also handle records by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3725](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3725) - Update SA1119 to allow parenthesis around a ref ternary conditional expression when it is the left-hand side of an assigment by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3737](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3737) - Update SA1119 to allow parenthesized switch expressions followed by an invocation by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3733](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3733) - Add c# 12 test project by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3734](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3734) - Run tests in parallel jobs by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3740](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3740) - Update SA1010 to accept whitespace before collection initializers by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3745](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3745) - Update SA1513 to not require a blank line if the closing brace is at the end of a collection expression by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3746](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3746) - Update SA1118 to allow multi-line collection expressions by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3749](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3749) - Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3750](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3750) - Update SA1008 to allow space before the opening parenthesis of a using alias definition of a tuple type by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3748](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3748) - Update documentation for SA1102 to contain compilable code examples by [@​arphox](https://togithub.com/arphox) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755) - Update SA1008 to not crash if there is no previous token by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3741](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3741) - Change default value of test property CodeActionValidationMode to SemanticStructure instead of None and update so that tests still pass by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3753](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3753) - Allow inheritdoc for class constructors with base types by [@​MartyIX](https://togithub.com/MartyIX) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719) - Fix that SA1134 Fix All maybe non-deterministic by [@​pdelvo](https://togithub.com/pdelvo) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/2853](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/2853) - Coverage improvements by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3675](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3675) - Fix SA1131 to not treat "complex" expressions as a literal by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3760](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3760) #### New Contributors - [@​martin-strecker-sonarsource](https://togithub.com/martin-strecker-sonarsource) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711) - [@​arphox](https://togithub.com/arphox) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755) - [@​MartyIX](https://togithub.com/MartyIX) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719) **Full Changelog**: DotNetAnalyzers/StyleCopAnalyzers@1.2.0-beta.507...1.2.0-beta.556 ### [`v1.2.0-beta.553`](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.553) [Compare Source](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.507...1.2.0-beta.553) ##### What's Changed - Update SA1011 to forbid trailing space before the end of a switch case by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3674](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3674) - Rewrite IOperationWrapper as a wrapper structure around IOperation by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3611](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3611) - Update SA1202 to support interfaces (C# 8) and records (C# 9, 10) by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3694](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3694) - Update documentation for SA1308 to also mention prefix "t\_" by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3697](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3697) - Update SA1642 and its code fix to handle record structs correctly by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3696](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3696) - Update dependencies by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3700](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3700) - Mark several test classes as partial by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3702](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3702) - Add missing test files and fix inheritance by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3703](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3703) - Generate and validate derived test classes by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3704](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3704) - Update SA1011 to not require space before a range operator by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3709](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3709) - Update SA1131 to treat methods as constants by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3710](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3710) - Avoid allocations in CanWrap... methods by [@​martin-strecker-sonarsource](https://togithub.com/martin-strecker-sonarsource) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711) - Update SA1648 to accept inheritdoc on members implemented from static abstract/virtual interface members by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3715](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3715) - Update SA1600 to also handle records by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3725](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3725) - Update SA1119 to allow parenthesis around a ref ternary conditional expression when it is the left-hand side of an assigment by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3737](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3737) - Update SA1119 to allow parenthesized switch expressions followed by an invocation by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3733](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3733) - Add c# 12 test project by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3734](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3734) - Run tests in parallel jobs by [@​sharwell](https://togithub.com/sharwell) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3740](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3740) - Update SA1010 to accept whitespace before collection initializers by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3745](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3745) - Update SA1513 to not require a blank line if the closing brace is at the end of a collection expression by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3746](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3746) - Update SA1118 to allow multi-line collection expressions by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3749](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3749) - Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3750](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3750) - Update SA1008 to allow space before the opening parenthesis of a using alias definition of a tuple type by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3748](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3748) - Update documentation for SA1102 to contain compilable code examples by [@​arphox](https://togithub.com/arphox) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755) - Update SA1008 to not crash if there is no previous token by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3741](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3741) - Change default value of test property CodeActionValidationMode to SemanticStructure instead of None and update so that tests still pass by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3753](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3753) - Allow inheritdoc for class constructors with base types by [@​MartyIX](https://togithub.com/MartyIX) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719) - Fix that SA1134 Fix All maybe non-deterministic by [@​pdelvo](https://togithub.com/pdelvo) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/2853](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/2853) - Coverage improvements by [@​bjornhellander](https://togithub.com/bjornhellander) in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3675](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3675) ##### New Contributors - [@​martin-strecker-sonarsource](https://togithub.com/martin-strecker-sonarsource) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3711) - [@​arphox](https://togithub.com/arphox) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3755) - [@​MartyIX](https://togithub.com/MartyIX) made their first contribution in [https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719](https://togithub.com/DotNetAnalyzers/StyleCopAnalyzers/pull/3719) **Full Changelog**: DotNetAnalyzers/StyleCopAnalyzers@1.2.0-beta.507...1.2.0-beta.553 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ThorstenSauter/NoPlan). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2575
I'm not sure if the fix is correct or not. Hopefully it is.