Update SA1206 to handle c# 11 modifier "required" #3535

bjornhellander · 2022-07-17T09:19:29Z

codecov · 2022-07-17T09:53:44Z

Codecov Report

Merging #3535 (987eb30) into master (84e2324) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 987eb30 differs from pull request most recent head e40ab1f. Consider uploading reports for the commit e40ab1f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3535      +/-   ##
==========================================
- Coverage   93.25%   93.25%   -0.01%     
==========================================
  Files        1078     1078              
  Lines      113689   113709      +20     
  Branches     4020     4020              
==========================================
+ Hits       106024   106041      +17     
- Misses       6630     6633       +3     
  Partials     1035     1035

bjornhellander · 2023-02-11T13:59:23Z

Rebased and added the missing tests, @sharwell

KUTlime · 2023-02-13T17:02:53Z

@bjornhellander @sharwell How is this PR going? I have to write #pragmas more than I wish to. 🤷‍♀️

sharwell · 2023-02-17T20:20:47Z

StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1206DeclarationKeywordsMustFollowOrder.cs

+                if (currentModifierType == ModifierType.None)
+                {
+                    // Just ignore unknown modifiers, to avoid false positives before support for
+                    // new language features has been added.
+                    continue;
+                }


💭 I almost prefer the original behavior, otherwise support may never have been added.

I think that "never" is unlikely, but it would almost certainly have taken longer to be discovered. I was just trying to think about the user experience and for my part I would definitely prefer false negatives over false positives, but I can revert that change if you want me to. Just say the word.

@sharwell Could you please make you call here? Thank you.

Ok. I reverted this change now.

Imo behavior proposed by @bjornhellander is much better. We have required keyword for >6 months. This means users of stylecop either do not use SA1206 or do not use required keyword over this period.

@POnakS We do use it (required keyword) but we have to constantly disable SA1206 by pragma.

@KUTlime That's a mess, I've decided to just disable SA1206, as potential risk to my codebase is small, and having pragma everywhere is bigger concern IMO (you need to clean this up manually, and if you don't you won't have inspection)

DotNetAnalyzers#3527

bjornhellander · 2023-03-26T11:35:31Z

Anything else, @sharwell?

KUTlime · 2023-04-11T13:29:51Z

Ground control to @sharwell, are you alive? @bjornhellander requested a feedback. We are waiting for this.

sharwell · 2023-04-11T14:50:49Z

Getting hammered recently. Team is running on a light staff after some organizational changes.

KUTlime · 2023-04-11T14:58:00Z

Getting hammered recently. Team is running on a light staff after some organizational changes.

I recommend soft drink next time. They are call soft for a reason. 😉 #Sarcasm

bjornhellander · 2023-04-11T18:30:49Z

Thanks for the merge! 👍

bjornhellander mentioned this pull request Jul 28, 2022

Incorrect formatting behaviour when using SyntaxFactory.Block dotnet/roslyn#63013

Open

bjornhellander force-pushed the feature/sa1206-required branch from 75ce91d to a15c944 Compare August 10, 2022 06:37

bjornhellander mentioned this pull request Nov 27, 2022

Update Microsoft.CodeAnalysis.CSharp.Workspaces to version 4.4.0 for the c# 11 test project #3580

Merged

bjornhellander force-pushed the feature/sa1206-required branch 2 times, most recently from ec4568a to 259e3dd Compare February 11, 2023 13:12

bjornhellander changed the title ~~Update SA1206 to handle c# 11 modifier "required" [work in progress]~~ Update SA1206 to handle c# 11 modifier "required" Feb 11, 2023

sharwell reviewed Feb 17, 2023

View reviewed changes

bjornhellander force-pushed the feature/sa1206-required branch from 259e3dd to 6b80473 Compare March 26, 2023 08:14

Update SA1206 to handle c# 11 modifier "required"

e40ab1f

DotNetAnalyzers#3527

bjornhellander force-pushed the feature/sa1206-required branch from 6b80473 to e40ab1f Compare March 26, 2023 09:35

sharwell approved these changes Apr 11, 2023

View reviewed changes

sharwell merged commit d02bf2b into DotNetAnalyzers:master Apr 11, 2023

sharwell added this to the 1.2-beta.next milestone Apr 11, 2023

bjornhellander deleted the feature/sa1206-required branch April 11, 2023 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update SA1206 to handle c# 11 modifier "required" #3535

Update SA1206 to handle c# 11 modifier "required" #3535

bjornhellander commented Jul 17, 2022 •

edited

Loading

codecov bot commented Jul 17, 2022 •

edited

Loading

bjornhellander commented Feb 11, 2023

KUTlime commented Feb 13, 2023

sharwell Feb 17, 2023

bjornhellander Feb 19, 2023

KUTlime Mar 10, 2023

bjornhellander Mar 26, 2023

POnakS Mar 26, 2023

KUTlime Mar 28, 2023

POnakS Mar 28, 2023

bjornhellander commented Mar 26, 2023

KUTlime commented Apr 11, 2023

sharwell commented Apr 11, 2023

KUTlime commented Apr 11, 2023

bjornhellander commented Apr 11, 2023

Update SA1206 to handle c# 11 modifier "required" #3535

Update SA1206 to handle c# 11 modifier "required" #3535

Conversation

bjornhellander commented Jul 17, 2022 • edited Loading

codecov bot commented Jul 17, 2022 • edited Loading

Codecov Report

bjornhellander commented Feb 11, 2023

KUTlime commented Feb 13, 2023

sharwell Feb 17, 2023

Choose a reason for hiding this comment

bjornhellander Feb 19, 2023

Choose a reason for hiding this comment

KUTlime Mar 10, 2023

Choose a reason for hiding this comment

bjornhellander Mar 26, 2023

Choose a reason for hiding this comment

POnakS Mar 26, 2023

Choose a reason for hiding this comment

KUTlime Mar 28, 2023

Choose a reason for hiding this comment

POnakS Mar 28, 2023

Choose a reason for hiding this comment

bjornhellander commented Mar 26, 2023

KUTlime commented Apr 11, 2023

sharwell commented Apr 11, 2023

KUTlime commented Apr 11, 2023

bjornhellander commented Apr 11, 2023

bjornhellander commented Jul 17, 2022 •

edited

Loading

codecov bot commented Jul 17, 2022 •

edited

Loading