Fix ignored Namespace attribute in OperationLightupGenerator #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the wrapped `IOperation`s are in `Microsoft.CodeAnalysis.Operations` namespace and there are 6 more of them in `FlowAnalysis` namespace: ``` Microsoft.CodeAnalysis.FlowAnalysis.ICaughtExceptionOperation Microsoft.CodeAnalysis.FlowAnalysis.IFlowAnonymousFunctionOperation Microsoft.CodeAnalysis.FlowAnalysis.IFlowCaptureOperation Microsoft.CodeAnalysis.FlowAnalysis.IFlowCaptureReferenceOperation Microsoft.CodeAnalysis.FlowAnalysis.IIsNullOperation Microsoft.CodeAnalysis.FlowAnalysis.IStaticLocalInitializationSemaphoreOperation ``` This alternation is already configured in the `OperationInterfaces.xml` file, but the `Namespace` attribute was ignored in the code. https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/a559b3e58af09387aadc1372a504f9208bce4909/StyleCop.Analyzers/StyleCop.Analyzers/Lightup/OperationInterfaces.xml#L2542
Codecov Report
@@ Coverage Diff @@
## master #3378 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 1029 1029
Lines 111170 111170
Branches 3940 3940
=======================================
Hits 103891 103891
Misses 6263 6263
Partials 1016 1016 |
sharwell
requested changes
Aug 27, 2021
sharwell
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the wrapped
IOperations are inMicrosoft.CodeAnalysis.Operationsnamespace and there are 6 more of them inFlowAnalysisnamespace:This alternation is already configured in the
OperationInterfaces.xmlfile, but theNamespaceattribute was ignored in the code.StyleCopAnalyzers/StyleCop.Analyzers/StyleCop.Analyzers/Lightup/OperationInterfaces.xml
Line 2542 in a559b3e
Current behavior:
Using
IFlowAnonymousFunctionOperationWrapper.FromOperation(anonymousFunction)throws cast exception, becauseIsInstanceandLightupHelpers.CanWrapOperationfinds the key, but returnsnullvalue for the type.