SA1130: Handle optional named arguments correctly #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3289 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 1029 1029
Lines 111170 111253 +83
Branches 3940 3944 +4
=======================================
+ Hits 103891 103973 +82
- Misses 6263 6264 +1
Partials 1016 1016 |
sharwell
reviewed
Mar 10, 2021
StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1130UseLambdaSyntax.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1130UseLambdaSyntax.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1130UseLambdaSyntax.cs
Outdated
Show resolved
Hide resolved
StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1130UnitTests.cs
Show resolved
Hide resolved
…ing conditions)
…nt to reproduce the issue
…e-optional-named-args-correctly
|
@sharwell is there anything else I can/should do with this MR? |
sharwell
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3279,
NullReferenceExceptionis thrown when delegate is used as (optional) named parameter and argument index doesn't match method signature.Fix is handling special case when argument is used with name, e.g.
F(argName: delegate { ... }), otherwise everything works as before.