Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for missing edge cases in SA1600 #2779

Merged
merged 2 commits into from
Sep 10, 2018

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Sep 9, 2018

  • Test fields with documentInternalElements configured
  • Test private protected accessibility (C# 7.2+)
  • Fix bugs revealed by the new private protected tests

@codecov
Copy link

codecov bot commented Sep 9, 2018

Codecov Report

Merging #2779 into master will increase coverage by <.01%.
The diff coverage is 98.24%.

@@            Coverage Diff             @@
##           master    #2779      +/-   ##
==========================================
+ Coverage   97.37%   97.38%   +<.01%     
==========================================
  Files         751      752       +1     
  Lines       99421    99590     +169     
  Branches     3263     3267       +4     
==========================================
+ Hits        96816    96982     +166     
- Misses       1736     1738       +2     
- Partials      869      870       +1

@vweijsters vweijsters merged commit f0cb8bb into DotNetAnalyzers:master Sep 10, 2018
@sharwell sharwell deleted the sa1600-tests branch September 10, 2018 21:06
@sharwell sharwell added this to the 1.1.0 Beta 10 milestone Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants