Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add file header decoration comments if configured #2087

Merged
merged 5 commits into from
Jul 14, 2016
Merged

add file header decoration comments if configured #2087

merged 5 commits into from
Jul 14, 2016

Conversation

ThomasZitzler
Copy link

Fixes #2086

I have written no test yet, I first want to know if you accept this.

@codecov-io
Copy link

Current coverage is 93.37%

Merging #2087 into master will increase coverage by +0.05% as of d11b675

@@            master   #2087   diff @@
======================================
  Files          566     566       
  Stmts        35887   36005   +118
  Branches      2311    2321    +10
  Methods                          
======================================
+ Hit          33493   33618   +125
- Partial        759     762     +3
+ Missed        1635    1625    -10

Review entire Coverage Diff as of d11b675

Powered by Codecov. Updated on successful CI builds.

@ThomasZitzler
Copy link
Author

Added a test now. Anything else I have to do?

@vweijsters
Copy link
Contributor

As the settings file format is updated, the following files should be updated as well:

  • documentation/Configuration.md
  • StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json

@vweijsters
Copy link
Contributor

The code looks good to me.

zitzltho added 2 commits March 14, 2016 20:29
documentation for header decoration
cc191fe
Fix duplicate decoration in fix for SA1638
b4fa9f4 
When running the fix for SA1638, the header decoration is duplicated
@ThomasZitzler
Copy link
Author

I discovered a bug that the fix for SA1638 creates duplicate decorations. I fixed it with the last commit. Is there anything else to do?

pdelvo
pdelvo reviewed Apr 8, 2016
View reviewed changes
StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json
@@ -194,6 +194,11 @@
"description": "Determines whether the file header should be wrapped in the StyleCop-standard XML structure.",
"default": true
},
"headerDecoration": {
"type": "boolean",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not familiar with json schemas, but shouldn't this be string?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right, probably copy+paste :-)

@pdelvo
Copy link
Member

pdelvo commented Apr 8, 2016

Other then the minor comment this looks good to me. @sharwell should be back next week to merge this if he does not have other comments on this..

@sharwell sharwell added this to the 1.1.0 Beta 1 milestone Jul 14, 2016
@sharwell sharwell self-assigned this Jul 14, 2016
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this pull request Jul 14, 2016
@sharwell
Merge pull request DotNetAnalyzers#2087 from ThomasZitzler/fileheaderfix
0d21757 
add file header decoration comments if configured
@sharwell sharwell merged commit b63e425 into DotNetAnalyzers:master Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sharwell sharwell

@vweijsters vweijsters

Labels
None yet
Projects
None yet
Milestone
1.1.0 Beta 1
Development

Successfully merging this pull request may close these issues.
5 participants
@ThomasZitzler @codecov-io @vweijsters @pdelvo @sharwell