Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IsValidNewMemberName handling of parameters and locals #1858

Merged
merged 1 commit into from
Nov 28, 2015
Merged

Improve IsValidNewMemberName handling of parameters and locals #1858

merged 1 commit into from
Nov 28, 2015

Conversation

sharwell
Copy link
Member

Fixes #1315

@sharwell sharwell added this to the 1.0.0 RC 1 milestone Nov 28, 2015
@codecov-io
Copy link

Current coverage is 79.30%

Merging #1858 into master will increase coverage by +0.02% as of b1f010e

@@            master   #1858   diff @@
======================================
  Files          554     554       
  Stmts        34258   34358   +100
  Branches      9491    9500     +9
  Methods                          
======================================
+ Hit          27163   27246    +83
- Partial       5517    5541    +24
+ Missed        1578    1571     -7

Review entire Coverage Diff as of b1f010e

Powered by Codecov. Updated on successful CI builds.

@vweijsters
Copy link
Contributor

👍 Looks good to me.

There is a possible interference with SX1309(S), but I've created #1861 for that.

sharwell added a commit that referenced this pull request Nov 28, 2015
@sharwell
Merge pull request #1858 from sharwell/fix-1315
764eb9a 
Improve IsValidNewMemberName handling of parameters and locals
@sharwell sharwell merged commit 764eb9a into DotNetAnalyzers:master Nov 28, 2015
@sharwell sharwell deleted the fix-1315 branch November 28, 2015 15:23
@sharwell sharwell mentioned this pull request Dec 2, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vweijsters vweijsters

Labels
None yet
Projects
None yet
Milestone
1.0.0 RC 1
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @codecov-io @vweijsters