Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IsValidNewMemberName accuracy #1853

Merged
merged 2 commits into from
Nov 27, 2015

Conversation

sharwell
Copy link
Member

This update follows the discussion in #1849.

@sharwell sharwell added this to the 1.0.0 RC 1 milestone Nov 27, 2015
@codecov-io
Copy link

Current coverage is 79.28%

Merging #1853 into master will decrease coverage by -0.07% as of b11498a

@@            master   #1853   diff @@
======================================
  Files          554     554       
  Stmts        34242   34258    +16
  Branches      9484    9491     +7
  Methods                          
======================================
- Hit          27173   27161    -12
- Partial       5512    5519     +7
- Missed        1557    1578    +21

Review entire Coverage Diff as of b11498a

Powered by Codecov. Updated on successful CI builds.

@vweijsters
Copy link
Contributor

👍

@sharwell
Copy link
Member Author

@vweijsters I didn't mean to include the change for enum members in this pull request. I removed that commit.

sharwell added a commit that referenced this pull request Nov 27, 2015
Improve IsValidNewMemberName accuracy
@sharwell sharwell merged commit 3e23b10 into DotNetAnalyzers:master Nov 27, 2015
@sharwell sharwell deleted the validname-accuracy branch November 27, 2015 22:38
@sharwell sharwell added the fixed label Nov 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants