Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging for SA1205 #1846

Merged
merged 2 commits into from
Nov 27, 2015
Merged

Conversation

sharwell
Copy link
Member

Closes #1778

StyleCop Analyzers is able to determine the accessibility of elements whether
or not it is declared, so the SA1205 suggestions to the contrary are
misleading.
@sharwell sharwell added this to the 1.0.0 RC 1 milestone Nov 27, 2015
@codecov-io
Copy link

Current coverage is 79.33%

Merging #1846 into master will decrease coverage by -0.01% as of 2173a75

@@            master   #1846   diff @@
======================================
  Files          554     554       
  Stmts        34053   34050     -3
  Branches      9405    9405       
  Methods                          
======================================
- Hit          27018   27013     -5
- Partial       5455    5457     +2
  Missed        1580    1580       

Review entire Coverage Diff as of 2173a75

Powered by Codecov. Updated on successful CI builds.

@pdelvo
Copy link
Member

pdelvo commented Nov 27, 2015

👍

sharwell added a commit that referenced this pull request Nov 27, 2015
Improve messaging for SA1205
@sharwell sharwell merged commit 932e6e9 into DotNetAnalyzers:master Nov 27, 2015
@sharwell sharwell deleted the fix-1778 branch November 27, 2015 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants