Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lightup support for fallback base syntax types #3258

Open
sharwell opened this issue Dec 3, 2020 · 0 comments
Open

Fix lightup support for fallback base syntax types #3258

sharwell opened this issue Dec 3, 2020 · 0 comments

Comments

@sharwell
Copy link
Member

sharwell commented Dec 3, 2020 •
edited
Loading

  • BaseObjectCreationExpressionSyntax should fall back to ObjectCreationExpressionSyntax
  • BaseParameterSyntax should fall back to ParameterSyntax
  • ExpressionOrPatternSyntax should fall back to both ExpressionSyntax and PatternSyntax
  • MemberDeclarationSyntaxExtensions should fall back to implementations in derived types

Originally posted by @sharwell in #3246 (comment)
@sharwell sharwell mentioned this issue Dec 3, 2020
Merged
@sharwell sharwell changed the title BaseObjectCreationExpressionSyntax should fall back to ObjectCreationExpressionSyntax Fix lightup support for fallback base syntax types Dec 3, 2020
danmoseley added a commit to danmoseley/StyleCopAnalyzers that referenced this issue Dec 21, 2020
@danmoseley
Test for DotNetAnalyzers#3258
3ef3489
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Dec 21, 2020
@sharwell
Fix fallback support for BaseObjectCreationExpressionSyntaxWrapper
be71d50 
See DotNetAnalyzers#3258
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Dec 21, 2020
@sharwell
Fix fallback support for BaseObjectCreationExpressionSyntaxWrapper
f851c85 
See DotNetAnalyzers#3258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sharwell