Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1131 does not consider default literal expressions as constant #2675

Closed
sharwell opened this issue May 7, 2018 · 0 comments
Closed

SA1131 does not consider default literal expressions as constant #2675

sharwell opened this issue May 7, 2018 · 0 comments
Assignees
@sharwell
Labels
bug c# 7.1 fixed
Milestone
1.1.0 Beta 7

Comments

@sharwell
Copy link
Member

sharwell commented May 7, 2018 •
edited
Loading

SA1131 reports a diagnostic when default literal expressions are used on the right hand side of a comparison.
@sharwell sharwell changed the title SA1131 does not consider default expressions as constant SA1131 does not consider default literal expressions as constant May 7, 2018
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue May 7, 2018
@sharwell
Update SA1131 to support default literal expressions
659fd5b 
Fixes DotNetAnalyzers#2675
@sharwell sharwell mentioned this issue May 7, 2018
Merged
@sharwell sharwell self-assigned this May 7, 2018
@sharwell sharwell added this to the 1.1.0 Beta 7 milestone May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
bug c# 7.1 fixed
Projects
None yet
Milestone
1.1.0 Beta 7
Development

No branches or pull requests
2 participants
@sharwell @vweijsters