Opt-out of Moq's Verify() / Setup() in IDISP013

DotNetAnalyzers · Mar 3, 2024 · 92f64f1 · 92f64f1
1 parent 6b35c3a
commit 92f64f1
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/IDisposableAnalyzers.Test/IDISP013AwaitInUsingTests/Valid.Ignore.cs b/IDisposableAnalyzers.Test/IDISP013AwaitInUsingTests/Valid.Ignore.cs
@@ -32,5 +32,34 @@ public void M()
                 """;
             RoslynAssert.Valid(Analyzer, code);
         }
+
+        [Test]
+        public static void MoqSetupVerifyAsync()
+        {
+            var code = @"
+namespace N
+{
+    using System;
+    using System.IO;
+    using System.Threading;
+    using Moq;
+
+    public class C
+    {
+        public void M()
+        {
+            using (var stream = File.OpenRead(string.Empty))
+            {
+                var mock = new Mock<Stream>();
+                mock.Setup(x => x.ReadAsync(It.IsAny<Memory<byte>>(), It.IsAny<CancellationToken>()))
+                    .ReturnsAsync(0);
+                mock.Verify(x => x.ReadAsync(It.IsAny<Memory<byte>>(), It.IsAny<CancellationToken>()));
+            }
+        }
+    }
+}";
+
+            RoslynAssert.Valid(Analyzer, code);
+        }
     }
 }
diff --git a/IDisposableAnalyzers/Analyzers/ReturnValueAnalyzer.cs b/IDisposableAnalyzers/Analyzers/ReturnValueAnalyzer.cs
@@ -136,7 +136,7 @@ static bool ShouldAwait(SyntaxNodeAnalysisContext context, ExpressionSyntax retu
             {
                 if (returnValue.TryFirstAncestor(out InvocationExpressionSyntax? ancestor) &&
                     ancestor.TryGetMethodName(out var ancestorName) &&
-                    ancestorName == "ThrowsAsync")
+                    ancestorName is "ThrowsAsync" or "Setup" or "Verify")
                 {
                     return false;
                 }